Arlolra has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/234683

Change subject: Fix an edge case in roundtripping unedited interwiki links
......................................................................

Fix an edge case in roundtripping unedited interwiki links

Change-Id: Icb0810028a202d664332e95c716d008aad547dde
---
M lib/wts.LinkHandler.js
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/83/234683/1

diff --git a/lib/wts.LinkHandler.js b/lib/wts.LinkHandler.js
index 92e1afd..df068f9 100644
--- a/lib/wts.LinkHandler.js
+++ b/lib/wts.LinkHandler.js
@@ -201,9 +201,11 @@
                                localPrefix += oldPrefix[1] + ':';
                        }
 
-                       // should we preserve the old prefix?
-                       if (oldPrefix && (
-                                       oldPrefix[1].toLowerCase() === 
interWikiMatch[0].toLowerCase() ||
+                       if (target.fromsrc && !target.notmodified) {
+                               /* jshint noempty: false */
+                               // Leave the target alone!
+                       } else if (oldPrefix &&  // should we preserve the old 
prefix?
+                                       (oldPrefix[1].toLowerCase() === 
interWikiMatch[0].toLowerCase() ||
                                        // Check if the old prefix mapped to 
the same URL as
                                        // the new one. Use the old one if 
that's the case.
                                        // Example: [[w:Foo]] vs. [[:en:Foo]]

-- 
To view, visit https://gerrit.wikimedia.org/r/234683
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb0810028a202d664332e95c716d008aad547dde
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <abrea...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to