Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/234696
Change subject: resourceloader: Don't create empty objects for every module
......................................................................
resourceloader: Don't create empty objects for every module
For modules without one or more of 'scripts', 'styles', 'messages'
and 'templates'; don't needlessly create empty placeholder objects.
Except for 'scripts', these were already handled conditionally.
Bug: T105162
Change-Id: Ic1b3b09474e0b50b438b111a4f62368ceab4e732
---
M resources/src/mediawiki/mediawiki.js
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/96/234696/1
diff --git a/resources/src/mediawiki/mediawiki.js
b/resources/src/mediawiki/mediawiki.js
index d48621d..57420f2 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -1227,6 +1227,9 @@
$.globalEval( script );
markModuleReady();
}
+ } else {
+ // Module
without script
+
markModuleReady();
}
} );
} catch ( e ) {
@@ -1783,10 +1786,10 @@
throw new Error( 'module
already implemented: ' + module );
}
// Attach components
- registry[module].script = script || [];
- registry[module].style = style || {};
- registry[module].messages = messages ||
{};
- registry[module].templates = templates
|| {};
+ registry[module].script = script ||
null;
+ registry[module].style = style || null;
+ registry[module].messages = messages ||
null;
+ registry[module].templates = templates
|| null;
// The module may already have been
marked as erroneous
if ( $.inArray( registry[module].state,
['error', 'missing'] ) === -1 ) {
registry[module].state =
'loaded';
--
To view, visit https://gerrit.wikimedia.org/r/234696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1b3b09474e0b50b438b111a4f62368ceab4e732
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
