jenkins-bot has submitted this change and it was merged. Change subject: Convert some fields to local variables. ......................................................................
Convert some fields to local variables. This patch converts some fields that are only used in a single method to local variables, to optimise performance and maintain code tidiness. Change-Id: Ia38f84ecdc87c66a3924b06b43d19e31f7131691 --- M app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java M app/src/main/java/org/wikipedia/page/linkpreview/SwipeableBottomDialog.java M app/src/main/java/org/wikipedia/search/SearchArticlesFragment.java 3 files changed, 3 insertions(+), 6 deletions(-) Approvals: BearND: Looks good to me, approved jenkins-bot: Verified diff --git a/app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java b/app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java index a4e71aa..2cc2af6 100644 --- a/app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java +++ b/app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java @@ -61,7 +61,6 @@ private View bottomContentContainer; private TextView pageLastUpdatedText; private TextView pageLicenseText; - private TextView pageExternalLink; private View readMoreContainer; private ListView readMoreList; @@ -88,7 +87,7 @@ readMoreContainer = bottomContentContainer.findViewById(R.id.read_more_container); readMoreList = (ListView)bottomContentContainer.findViewById(R.id.read_more_list); - pageExternalLink = (TextView) bottomContentContainer.findViewById(R.id.page_external_link); + TextView pageExternalLink = (TextView) bottomContentContainer.findViewById(R.id.page_external_link); pageExternalLink.setPaintFlags(pageExternalLink.getPaintFlags() | Paint.UNDERLINE_TEXT_FLAG); pageExternalLink.setOnClickListener(new View.OnClickListener() { @Override diff --git a/app/src/main/java/org/wikipedia/page/linkpreview/SwipeableBottomDialog.java b/app/src/main/java/org/wikipedia/page/linkpreview/SwipeableBottomDialog.java index babd012..8d5bbc8 100644 --- a/app/src/main/java/org/wikipedia/page/linkpreview/SwipeableBottomDialog.java +++ b/app/src/main/java/org/wikipedia/page/linkpreview/SwipeableBottomDialog.java @@ -50,7 +50,6 @@ */ public abstract class SwipeableBottomDialog extends DialogFragment { private final List<View> dialogViews = new ArrayList<>(); - private ViewGroup rootView; private ListView dialogListView; private int dialogPeekHeight; @@ -76,7 +75,7 @@ int displayWidth = getDialogWidth(); int displayHeight = inflater.getContext().getResources().getDisplayMetrics().heightPixels; - rootView = (ViewGroup) inflater.inflate(R.layout.dialog_bottom_swipe, container); + ViewGroup rootView = (ViewGroup) inflater.inflate(R.layout.dialog_bottom_swipe, container); dialogViews.add(makeSpaceView(displayWidth, 1)); dialogViews.add(makeSpaceView(displayWidth, dialogPeekHeight)); diff --git a/app/src/main/java/org/wikipedia/search/SearchArticlesFragment.java b/app/src/main/java/org/wikipedia/search/SearchArticlesFragment.java index e19cf49..4d4d897 100644 --- a/app/src/main/java/org/wikipedia/search/SearchArticlesFragment.java +++ b/app/src/main/java/org/wikipedia/search/SearchArticlesFragment.java @@ -44,7 +44,6 @@ private EditText searchEditText; private SearchFunnel funnel; private TextView langButton; - private FrameLayout langButtonContainer; public SearchFunnel getFunnel() { return funnel; @@ -287,7 +286,7 @@ LinearLayout enabledSearchBar = (LinearLayout) getActivity().findViewById(R.id.search_bar_enabled); TextView searchButton = (TextView) getActivity().findViewById(R.id.main_search_bar_text); langButton = (TextView) getActivity().findViewById(R.id.search_lang_button); - langButtonContainer = (FrameLayout) getActivity().findViewById(R.id.search_lang_button_container); + FrameLayout langButtonContainer = (FrameLayout) getActivity().findViewById(R.id.search_lang_button_container); if (enabled) { // set up the language picker -- To view, visit https://gerrit.wikimedia.org/r/234712 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia38f84ecdc87c66a3924b06b43d19e31f7131691 Gerrit-PatchSet: 2 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Deskana <dga...@wikimedia.org> Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org> Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits