Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/234911
Change subject: Don't display broken, unparsed comments in client recent changes
......................................................................
Don't display broken, unparsed comments in client recent changes
If $comment is a string, then it is probably the new comments
format that we will eventually parse and display nicely. This
is not implemented yet and we shouldn't pass these yet to
the ExternalComment objects.
afaik, other comment strings are not used anymore and just
defaulting to the generic 'wikibase-comment-update' is okayish
in this case and is what we want for now.
Bug: T110823
Change-Id: I343acd5c755f9fb9480d2280982b54df9695a137
---
M client/includes/recentchanges/ExternalChangeFactory.php
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/11/234911/1
diff --git a/client/includes/recentchanges/ExternalChangeFactory.php
b/client/includes/recentchanges/ExternalChangeFactory.php
index fbfd5b1..8e28d96 100644
--- a/client/includes/recentchanges/ExternalChangeFactory.php
+++ b/client/includes/recentchanges/ExternalChangeFactory.php
@@ -163,8 +163,6 @@
} else {
$newComment['key'] = $comment['message'];
}
- } elseif ( is_string( $comment ) ) {
- $newComment['key'] = $comment;
}
return $newComment;
--
To view, visit https://gerrit.wikimedia.org/r/234911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I343acd5c755f9fb9480d2280982b54df9695a137
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
