Filippo Giunchedi has submitted this change and it was merged.

Change subject: grafana: graphite is the default datasource
......................................................................


grafana: graphite is the default datasource

With multiple datasources, when we add a graph panel the interface fails
to pick a datasource and fallback to 'null'.  That causes a stacktrace
in the frontend web interface which prevents the default empty graph
from showing. We end up with a graph panel that does not display and
thus can not be edited.

The grafana v1.9 installation documentation suggests to set one of the
datasources as the default. That might fix the null datasource error.

Reference:
http://docs.grafana.org/v1.9/installation/

Bug: T110317
Change-Id: I781ac6c8fb8730f05e46dd49b5e338c9ee6a4cde
---
M manifests/role/grafana.pp
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Filippo Giunchedi: Verified; Looks good to me, approved



diff --git a/manifests/role/grafana.pp b/manifests/role/grafana.pp
index 88c5475..0166364 100644
--- a/manifests/role/grafana.pp
+++ b/manifests/role/grafana.pp
@@ -13,6 +13,7 @@
         config => {
             datasources => {
                 graphite      => {
+                    'default'     => 'true',
                     type          => 'graphite',
                     url           => "//graphite.${domain_suffix}",
                     render_method => 'GET',

-- 
To view, visit https://gerrit.wikimedia.org/r/233936
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I781ac6c8fb8730f05e46dd49b5e338c9ee6a4cde
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <has...@free.fr>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to