Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/236010

Change subject: Avoid exponential years in MwTimeIsoFormatter
......................................................................

Avoid exponential years in MwTimeIsoFormatter

It seems that some PHP versions magically format very large floating
point numbers as "1,0E+16". We do not want that for years.

This is already covered by a test.

Bug: T111343
Change-Id: Ie61114808e68c3032f1c21213f624ba6e9a79240
---
M lib/includes/formatters/MwTimeIsoFormatter.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/10/236010/1

diff --git a/lib/includes/formatters/MwTimeIsoFormatter.php 
b/lib/includes/formatters/MwTimeIsoFormatter.php
index 18eb622..3fb5a54 100644
--- a/lib/includes/formatters/MwTimeIsoFormatter.php
+++ b/lib/includes/formatters/MwTimeIsoFormatter.php
@@ -279,7 +279,7 @@
 
                if ( empty( $msg ) ) {
                        // TODO: This needs a message.
-                       return $number . ( $isBCE ? ' BCE' : '' );
+                       return sprintf( '%.0f', $number ) . ( $isBCE ? ' BCE' : 
'' );
                }
 
                return $this->getMessage(

-- 
To view, visit https://gerrit.wikimedia.org/r/236010
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie61114808e68c3032f1c21213f624ba6e9a79240
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to