Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/236520
Change subject: Remove @since tags from private properties and methods
......................................................................
Remove @since tags from private properties and methods
This also drops an unused property.
This is a direct follow-up for the stuff that became private in
I3dbe3f7.
Change-Id: Iaf3a38006892e512272973d36c83bb4d844ab1e3
---
M repo/includes/ChangeOp/ChangeOpMainSnak.php
M repo/includes/ChangeOp/ChangeOpQualifier.php
M repo/includes/ChangeOp/ChangeOpQualifierRemove.php
M repo/includes/ChangeOp/ChangeOpReference.php
M repo/includes/ChangeOp/ChangeOpReferenceRemove.php
M repo/includes/ChangeOp/ChangeOpStatementRank.php
M repo/includes/ValueParserFactory.php
M repo/includes/specials/SpecialNewProperty.php
M repo/includes/store/sql/EntityPerPageBuilder.php
M repo/includes/store/sql/SqlIdGenerator.php
M repo/includes/store/sql/TermSearchKeyBuilder.php
11 files changed, 0 insertions(+), 56 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/20/236520/1
diff --git a/repo/includes/ChangeOp/ChangeOpMainSnak.php
b/repo/includes/ChangeOp/ChangeOpMainSnak.php
index 1689d43..d55892c 100644
--- a/repo/includes/ChangeOp/ChangeOpMainSnak.php
+++ b/repo/includes/ChangeOp/ChangeOpMainSnak.php
@@ -25,15 +25,11 @@
class ChangeOpMainSnak extends ChangeOpBase {
/**
- * @since 0.4
- *
* @var string
*/
private $statementGuid;
/**
- * @since 0.4
- *
* @var Snak
*/
private $snak;
diff --git a/repo/includes/ChangeOp/ChangeOpQualifier.php
b/repo/includes/ChangeOp/ChangeOpQualifier.php
index 31d861e..ae3d6f8 100644
--- a/repo/includes/ChangeOp/ChangeOpQualifier.php
+++ b/repo/includes/ChangeOp/ChangeOpQualifier.php
@@ -22,22 +22,16 @@
class ChangeOpQualifier extends ChangeOpBase {
/**
- * @since 0.4
- *
* @var string
*/
private $statementGuid;
/**
- * @since 0.4
- *
* @var Snak
*/
private $snak;
/**
- * @since 0.4
- *
* @var string
*/
private $snakHash;
diff --git a/repo/includes/ChangeOp/ChangeOpQualifierRemove.php
b/repo/includes/ChangeOp/ChangeOpQualifierRemove.php
index 85253ee..fdd5999 100644
--- a/repo/includes/ChangeOp/ChangeOpQualifierRemove.php
+++ b/repo/includes/ChangeOp/ChangeOpQualifierRemove.php
@@ -20,15 +20,11 @@
class ChangeOpQualifierRemove extends ChangeOpBase {
/**
- * @since 0.5
- *
* @var string
*/
private $statementGuid;
/**
- * @since 0.5
- *
* @var string
*/
private $snakHash;
diff --git a/repo/includes/ChangeOp/ChangeOpReference.php
b/repo/includes/ChangeOp/ChangeOpReference.php
index 61cbe5e..4829a69 100644
--- a/repo/includes/ChangeOp/ChangeOpReference.php
+++ b/repo/includes/ChangeOp/ChangeOpReference.php
@@ -23,29 +23,21 @@
class ChangeOpReference extends ChangeOpBase {
/**
- * @since 0.4
- *
* @var string
*/
private $statementGuid;
/**
- * @since 0.4
- *
* @var Reference
*/
private $reference;
/**
- * @since 0.4
- *
* @var string
*/
private $referenceHash;
/**
- * @since 0.5
- *
* @var int|null
*/
private $index;
diff --git a/repo/includes/ChangeOp/ChangeOpReferenceRemove.php
b/repo/includes/ChangeOp/ChangeOpReferenceRemove.php
index 499be38..2b7e874 100644
--- a/repo/includes/ChangeOp/ChangeOpReferenceRemove.php
+++ b/repo/includes/ChangeOp/ChangeOpReferenceRemove.php
@@ -20,15 +20,11 @@
class ChangeOpReferenceRemove extends ChangeOpBase {
/**
- * @since 0.5
- *
* @var string
*/
private $statementGuid;
/**
- * @since 0.5
- *
* @var string
*/
private $referenceHash;
diff --git a/repo/includes/ChangeOp/ChangeOpStatementRank.php
b/repo/includes/ChangeOp/ChangeOpStatementRank.php
index b3ac655..517cbb5 100644
--- a/repo/includes/ChangeOp/ChangeOpStatementRank.php
+++ b/repo/includes/ChangeOp/ChangeOpStatementRank.php
@@ -20,15 +20,11 @@
class ChangeOpStatementRank extends ChangeOpBase {
/**
- * @since 0.4
- *
* @var string
*/
private $statementGuid;
/**
- * @since 0.4
- *
* @var integer
*/
private $rank;
diff --git a/repo/includes/ValueParserFactory.php
b/repo/includes/ValueParserFactory.php
index 0325045..15bf299 100644
--- a/repo/includes/ValueParserFactory.php
+++ b/repo/includes/ValueParserFactory.php
@@ -20,8 +20,6 @@
/**
* Maps parser id to ValueParser class or builder callback.
*
- * @since 0.5
- *
* @var callable[]
*/
private $parsers = array();
diff --git a/repo/includes/specials/SpecialNewProperty.php
b/repo/includes/specials/SpecialNewProperty.php
index b96bee4..d85343e 100644
--- a/repo/includes/specials/SpecialNewProperty.php
+++ b/repo/includes/specials/SpecialNewProperty.php
@@ -19,8 +19,6 @@
class SpecialNewProperty extends SpecialNewEntity {
/**
- * @since 0.2
- *
* @var string|null
*/
private $dataType = null;
diff --git a/repo/includes/store/sql/EntityPerPageBuilder.php
b/repo/includes/store/sql/EntityPerPageBuilder.php
index a206372..fbf2810 100644
--- a/repo/includes/store/sql/EntityPerPageBuilder.php
+++ b/repo/includes/store/sql/EntityPerPageBuilder.php
@@ -6,7 +6,6 @@
use Wikibase\DataModel\Entity\EntityIdParser;
use Wikibase\DataModel\Entity\EntityIdParsingException;
use Wikibase\Lib\Reporting\MessageReporter;
-use Wikibase\Repo\Content\EntityContentFactory;
use Wikibase\Repo\EntityNamespaceLookup;
use Wikibase\Repo\Store\EntityPerPage;
@@ -21,29 +20,16 @@
class EntityPerPageBuilder {
/**
- * @since 0.4
- *
* @var EntityPerPage
*/
private $entityPerPageTable;
/**
- * @since 0.4
- *
- * @var EntityContentFactory
- */
- private $entityContentFactory;
-
- /**
- * @since 0.4
- *
* @var EntityIdParser
*/
private $entityIdParser;
/**
- * @since 0.4
- *
* @var MessageReporter
*/
private $reporter;
@@ -68,8 +54,6 @@
private $entityNamespaceLookup;
/**
- * @since 0.5
- *
* @var array
*/
private $contentModels;
diff --git a/repo/includes/store/sql/SqlIdGenerator.php
b/repo/includes/store/sql/SqlIdGenerator.php
index 5e7cbfc..2e005ff 100644
--- a/repo/includes/store/sql/SqlIdGenerator.php
+++ b/repo/includes/store/sql/SqlIdGenerator.php
@@ -54,8 +54,6 @@
/**
* Generates and returns a new ID.
*
- * @since 0.1
- *
* @param DatabaseBase $database
* @param string $type
* @param bool $retry Retry once in case of e.g. race conditions.
Defaults to true.
diff --git a/repo/includes/store/sql/TermSearchKeyBuilder.php
b/repo/includes/store/sql/TermSearchKeyBuilder.php
index 21a0daa..cab8c92 100644
--- a/repo/includes/store/sql/TermSearchKeyBuilder.php
+++ b/repo/includes/store/sql/TermSearchKeyBuilder.php
@@ -18,15 +18,11 @@
class TermSearchKeyBuilder {
/**
- * @since 0.4
- *
* @var TermSqlIndex
*/
private $table;
/**
- * @since 0.4
- *
* @var MessageReporter|null
*/
private $reporter = null;
--
To view, visit https://gerrit.wikimedia.org/r/236520
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf3a38006892e512272973d36c83bb4d844ab1e3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
