jenkins-bot has submitted this change and it was merged. Change subject: Fix bug in jquery.ui.TemplatedWidget.tests.js ......................................................................
Fix bug in jquery.ui.TemplatedWidget.tests.js This was found by JSHint 2.9. This is split from Iebe5ce9. Change-Id: Ia7d67360ce3fde1fd6e23a1ca2027ee21f85768a --- M view/tests/qunit/jquery/ui/jquery.ui.TemplatedWidget.tests.js 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: JanZerebecki: Looks good to me, approved jenkins-bot: Verified diff --git a/view/tests/qunit/jquery/ui/jquery.ui.TemplatedWidget.tests.js b/view/tests/qunit/jquery/ui/jquery.ui.TemplatedWidget.tests.js index dab7e11..265100d 100644 --- a/view/tests/qunit/jquery/ui/jquery.ui.TemplatedWidget.tests.js +++ b/view/tests/qunit/jquery/ui/jquery.ui.TemplatedWidget.tests.js @@ -22,8 +22,9 @@ /** * @param {Object} templateShortCuts + * @param {jQuery} $subject */ - function checkShortCuts( templateShortCuts ) { + function checkShortCuts( templateShortCuts, $subject ) { $.each( templateShortCuts, function( key, selector ) { assert.ok( $subject.data( 'TemplatedWidget' )[key] instanceof $, @@ -57,7 +58,7 @@ ); if( testSets[i][1].templateShortCuts ) { - checkShortCuts( testSets[i][1].templateShortCuts ); + checkShortCuts( testSets[i][1].templateShortCuts, $subject ); } $subject.data( 'TemplatedWidget' ).destroy(); -- To view, visit https://gerrit.wikimedia.org/r/236542 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7d67360ce3fde1fd6e23a1ca2027ee21f85768a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: JanZerebecki <jan.wikime...@zerebecki.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits