Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/236828

Change subject: Fix deserialization for xml import tests
......................................................................

Fix deserialization for xml import tests

not sure why this didn't fail on jenkins, but
suspect it silently fails and doesn't through
an exception and then we make jenkins happy. :o

Bug: T111390
Change-Id: I107005ade5b25096364e788c83dfd98dabf9a23a
---
M repo/tests/phpunit/includes/RepoHooksTest.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/28/236828/1

diff --git a/repo/tests/phpunit/includes/RepoHooksTest.php 
b/repo/tests/phpunit/includes/RepoHooksTest.php
index 02d17df..2d394d8 100644
--- a/repo/tests/phpunit/includes/RepoHooksTest.php
+++ b/repo/tests/phpunit/includes/RepoHooksTest.php
@@ -128,7 +128,7 @@
     <revision>
       <contributor><username>Tester</username><id>0</id></contributor>
       <comment>Test</comment>
-      <text>{ "id":"Q123" }</text>
+      <text>{ "type": "item", "id":"Q123" }</text>
       <model>wikibase-item</model>
       <format>application/json</format>
     </revision>
@@ -150,7 +150,7 @@
     <revision>
       <contributor><username>Tester</username><id>0</id></contributor>
       <comment>Test</comment>
-      <text>{ "id":"Q123" }</text>
+      <text>{ "type": "item", "id":"Q123" }</text>
       <model>wikibase-item</model>
       <format>application/json</format>
     </revision>

-- 
To view, visit https://gerrit.wikimedia.org/r/236828
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I107005ade5b25096364e788c83dfd98dabf9a23a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to