Alexandros Kosiaris has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/237054

Change subject: apertium: fix logrotate bug caused by wildcards
......................................................................

apertium: fix logrotate bug caused by wildcards

Using wildcards in logrotate is risky. If the wildcard is not guarded by
extension or some other limiting term, it will match all files in the
directory rotating already rotated ones. Fix this by specifying the
exact names for apertium log files as they are known

Change-Id: Id2cd22ac02a64b3d001df37eca69b9006afa1f43
---
M modules/apertium/templates/logrotate.erb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/54/237054/1

diff --git a/modules/apertium/templates/logrotate.erb 
b/modules/apertium/templates/logrotate.erb
index 8c0dcaa..ca19192 100644
--- a/modules/apertium/templates/logrotate.erb
+++ b/modules/apertium/templates/logrotate.erb
@@ -2,7 +2,7 @@
 ### THIS FILE IS MANAGED BY PUPPET
 #####################################################################
 
-<%= @log_dir %>/apertium-apy.* {
+<%= @log_dir %>/apertium-apy.log <%= @log_dir %>/apertium-apy.err {
     daily
     copytruncate
     missingok

-- 
To view, visit https://gerrit.wikimedia.org/r/237054
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2cd22ac02a64b3d001df37eca69b9006afa1f43
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <akosia...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to