John Vandenberg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/237353
Change subject: Pass baserevid to wbeditentity
......................................................................
Pass baserevid to wbeditentity
436ccf2e introduced DataSite.editEntity with a restricted
list of parameters that could be passed to wbgetentities,
not including legal parameter baserevid, and implemented
WikibasePage.editEntity with baserevid being passed to
DataSite.editEntity.
As a result, baserevid has been silently discarded.
Add a warning when a parameter is ignored.
Change-Id: I38b305189a0a6fa437a78fed0118562348b1ac3d
---
M pywikibot/site.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/53/237353/1
diff --git a/pywikibot/site.py b/pywikibot/site.py
index 72d69a3..d494a98 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -6492,8 +6492,11 @@
params['baserevid'] = kwargs['baserevid']
params['token'] = self.tokens['edit']
for arg in kwargs:
- if arg in ['clear', 'data', 'exclude', 'summary']:
+ if arg in ['clear', 'data', 'exclude', 'summary', 'baserevid']:
params[arg] = kwargs[arg]
+ else:
+ warn('Unknown wbeditentity parameter {0} ignored'.format(arg),
+ UserWarning, 2)
params['data'] = json.dumps(data)
req = self._simple_request(**params)
data = req.submit()
--
To view, visit https://gerrit.wikimedia.org/r/237353
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38b305189a0a6fa437a78fed0118562348b1ac3d
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jay...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
