jenkins-bot has submitted this change and it was merged.
Change subject: Only use inverted icons for skins using the MediaWiki OOUI theme
......................................................................
Only use inverted icons for skins using the MediaWiki OOUI theme
Otherwise it causes flashes due to colors changing in skins that don't
use it, like MonoBook
Bug: T111821
Change-Id: I03acdbcbfa3912b439a18187d52944931e94506a
---
M Hooks.php
1 file changed, 8 insertions(+), 2 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Hooks.php b/Hooks.php
index 956caf0..75a3eb5 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -651,8 +651,14 @@
$url = SpecialPage::getTitleFor( 'Notifications'
)->getLocalURL();
- $msgLinkClasses = array( 'mw-echo-notifications-badge
oo-ui-image-invert oo-ui-iconElement oo-ui-iconElement-icon
oo-ui-icon-speechBubble' );
- $alertLinkClasses = array( 'mw-echo-notifications-badge
oo-ui-image-invert oo-ui-iconElement oo-ui-iconElement-icon' );
+ // HACK: inverted icons only work in the "MediaWiki" OOUI theme
+ // Avoid flashes in skins that don't use it (T111821)
+ $oouiImageClass = get_class( OOUI\Theme::singleton() ) ===
'OOUI\\MediaWikiTheme'
+ ? 'oo-ui-image-invert'
+ : '';
+
+ $msgLinkClasses = array( "mw-echo-notifications-badge
$oouiImageClass oo-ui-iconElement oo-ui-iconElement-icon
oo-ui-icon-speechBubble" );
+ $alertLinkClasses = array( "mw-echo-notifications-badge
$oouiImageClass oo-ui-iconElement oo-ui-iconElement-icon" );
if (
$msgCount != 0 && // no unread notifications
--
To view, visit https://gerrit.wikimedia.org/r/237424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03acdbcbfa3912b439a18187d52944931e94506a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
