Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/237390
Change subject: Add getter in WikibaseRepo for DataTypeDefinitions ...................................................................... Add getter in WikibaseRepo for DataTypeDefinitions This is needed by WikibaseQualityExternalValidation, to adjust it to use the new data types system. Bug: T111511 Change-Id: If359316ba19293539dab076c8e611a529fb9f720 --- M repo/includes/WikibaseRepo.php M repo/tests/phpunit/includes/WikibaseRepoTest.php 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/90/237390/2 diff --git a/repo/includes/WikibaseRepo.php b/repo/includes/WikibaseRepo.php index 9b328fb..8c07323 100644 --- a/repo/includes/WikibaseRepo.php +++ b/repo/includes/WikibaseRepo.php @@ -1356,6 +1356,13 @@ ); } + /** + * @return DataTypeDefinitions + */ + public function getDataTypeDefinitions() { + return $this->dataTypeDefinitions; + } + private function getMonolingualTextLanguages() { if ( $this->monolingualTextLanguages === null ) { $this->monolingualTextLanguages = new WikibaseContentLanguages(); diff --git a/repo/tests/phpunit/includes/WikibaseRepoTest.php b/repo/tests/phpunit/includes/WikibaseRepoTest.php index 42879ad..5e79011 100644 --- a/repo/tests/phpunit/includes/WikibaseRepoTest.php +++ b/repo/tests/phpunit/includes/WikibaseRepoTest.php @@ -269,4 +269,9 @@ $this->assertInstanceOf( 'Wikibase\PropertyInfoBuilder', $builder ); } + public function testGetDataTypeDefinitions() { + $dataTypeDefinitions = $this->getWikibaseRepo()->getDataTypeDefinitions(); + $this->assertInstanceOf( 'Wikibase\Lib\DataTypeDefinitions', $dataTypeDefinitions ); + } + } -- To view, visit https://gerrit.wikimedia.org/r/237390 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If359316ba19293539dab076c8e611a529fb9f720 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits