jenkins-bot has submitted this change and it was merged.
Change subject: Add @group tag and fix VocabularyUriFormatterTest
......................................................................
Add @group tag and fix VocabularyUriFormatterTest
Bug: T112086
Change-Id: I5d9600d40ece3b24b04cf68683ac0befac4d6e5d
---
M lib/tests/phpunit/formatters/VocabularyUriFormatterTest.php
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
JanZerebecki: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/tests/phpunit/formatters/VocabularyUriFormatterTest.php
b/lib/tests/phpunit/formatters/VocabularyUriFormatterTest.php
index 2e0ed2c..96a8bba 100644
--- a/lib/tests/phpunit/formatters/VocabularyUriFormatterTest.php
+++ b/lib/tests/phpunit/formatters/VocabularyUriFormatterTest.php
@@ -4,13 +4,17 @@
use OutOfBoundsException;
use PHPUnit_Framework_TestCase;
+use Wikibase\DataModel\Entity\BasicEntityIdParser;
use Wikibase\DataModel\Entity\EntityId;
-use Wikibase\DataModel\Services\EntityId\BasicEntityIdParser;
+use Wikibase\DataModel\Services\Lookup\LabelDescriptionLookupException;
use Wikibase\DataModel\Term\Term;
use Wikibase\Lib\VocabularyUriFormatter;
/**
* @covers Wikibase\Lib\VocabularyUriFormatter
+ *
+ * @group Wikibase
+ * @group WikibaseLIb
*
* @licence GNU GPL v2+
* @author Daniel Kinzler
@@ -41,7 +45,7 @@
->method( 'getLabel' )
->will( $this->returnCallback( function( EntityId $id )
{
if ( $id->getNumericId() > 1000 ) {
- throw new OutOfBoundsException( 'No
such label!' );
+ throw new
LabelDescriptionLookupException( $id, 'No such label!' );
}
return new Term( 'en', 'LABEL:' .
$id->getSerialization() );
} ) );
--
To view, visit https://gerrit.wikimedia.org/r/237474
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d9600d40ece3b24b04cf68683ac0befac4d6e5d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: JanZerebecki <jan.wikime...@zerebecki.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
