Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/237528
Change subject: Avoid master queries on image history view
......................................................................
Avoid master queries on image history view
* The path that needs READ_LATEST already calls load() as needed first
Bug: T92357
Change-Id: Ia06bba6c2853823add2e527bb1b013b64d3f020a
---
M includes/upload/UploadBase.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/28/237528/1
diff --git a/includes/upload/UploadBase.php b/includes/upload/UploadBase.php
index b06b91e..271162a 100644
--- a/includes/upload/UploadBase.php
+++ b/includes/upload/UploadBase.php
@@ -1706,7 +1706,7 @@
* Check if a user is the last uploader
*
* @param User $user
- * @param string $img Image name
+ * @param string|File $img Image name
* @return bool
*/
public static function userCanReUpload( User $user, $img ) {
@@ -1723,7 +1723,7 @@
return false;
}
- $img->load( File::READ_LATEST );
+ $img->load();
return $user->getId() == $img->getUser( 'id' );
}
--
To view, visit https://gerrit.wikimedia.org/r/237528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia06bba6c2853823add2e527bb1b013b64d3f020a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
