jenkins-bot has submitted this change and it was merged.

Change subject: Defer the "seen time" updates on GET requests
......................................................................


Defer the "seen time" updates on GET requests

Bug: T94448
Bug: T92357
Change-Id: I241662f9fd9aa13ef7468c9d76c26e58746f215a
---
M includes/special/SpecialNotifications.php
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/special/SpecialNotifications.php 
b/includes/special/SpecialNotifications.php
index 50acbd5..5a53bfe 100644
--- a/includes/special/SpecialNotifications.php
+++ b/includes/special/SpecialNotifications.php
@@ -142,7 +142,9 @@
 
                // Record time notifications have been seen
                $timestamp = wfTimestamp( TS_MW );
-               $echoSeenTime->setTime( $timestamp );
+               DeferredUpdates::addCallableUpdate( function() use ( 
$echoSeenTime, $timestamp ) {
+                       $echoSeenTime->setTime( $timestamp );
+               } );
        }
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/237530
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I241662f9fd9aa13ef7468c9d76c26e58746f215a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to