Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/237611
Change subject: Fixed Metrics/LineLength RuboCop offense ...................................................................... Fixed Metrics/LineLength RuboCop offense Bug: T112099 Change-Id: I1219dce4cb2f8ba3317d2865ead8f1881f8dcfab --- M .rubocop.yml D .rubocop_todo.yml M tests/browser/features/step_definitions/recent_collections_steps.rb M tests/browser/features/support/env.rb M tests/browser/features/support/pages/gather_recent_page.rb 5 files changed, 15 insertions(+), 20 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather refs/changes/11/237611/1 diff --git a/.rubocop.yml b/.rubocop.yml index d531804..84567a5 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,11 +1,8 @@ -inherit_from: .rubocop_todo.yml - AllCops: StyleGuideCopsOnly: true -# Uncomment when the violation is fixed -# Metrics/LineLength: -# Max: 100 +Metrics/LineLength: + Max: 100 Metrics/MethodLength: Enabled: false diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml deleted file mode 100644 index 2c03609..0000000 --- a/.rubocop_todo.yml +++ /dev/null @@ -1,12 +0,0 @@ -# This configuration was generated by -# `rubocop --auto-gen-config` -# on 2015-09-10 16:28:27 +0200 using RuboCop version 0.34.1. -# The point is for the user to remove these configuration records -# one by one as the offenses are removed from the code base. -# Note that changes in the inspected code, or installation of new -# versions of RuboCop, may require this file to be generated again. - -# Offense count: 26 -# Configuration parameters: AllowURI, URISchemes. -Metrics/LineLength: - Max: 112 diff --git a/tests/browser/features/step_definitions/recent_collections_steps.rb b/tests/browser/features/step_definitions/recent_collections_steps.rb index e02848e..c2588a1 100644 --- a/tests/browser/features/step_definitions/recent_collections_steps.rb +++ b/tests/browser/features/step_definitions/recent_collections_steps.rb @@ -12,7 +12,8 @@ end Then(/^I see more than 100 collections$/) do - expect(on(GatherRecentPage).collection_one_hundred_plus_one_element.when_present(10)).to be_visible + expect(on(GatherRecentPage).collection_one_hundred_plus_one_element.when_present(10)).to + be_visible end Then(/^the 101st collection has a title$/) do diff --git a/tests/browser/features/support/env.rb b/tests/browser/features/support/env.rb index c366ec2..195118d 100644 --- a/tests/browser/features/support/env.rb +++ b/tests/browser/features/support/env.rb @@ -4,7 +4,13 @@ module Gather def make_collection(label) - api.action('editlist', token_type: 'watch', label: label, titles: 'A|B|C|D', mode: 'update', perm: 'public') + api.action( + 'editlist', + token_type: 'watch', + label: label, + titles: 'A|B|C|D', + mode: 'update', + perm: 'public') end end World(Gather) diff --git a/tests/browser/features/support/pages/gather_recent_page.rb b/tests/browser/features/support/pages/gather_recent_page.rb index 4622611..44ffc8f 100644 --- a/tests/browser/features/support/pages/gather_recent_page.rb +++ b/tests/browser/features/support/pages/gather_recent_page.rb @@ -5,6 +5,9 @@ a(:my_collections_button, css: '.button-bar a', index: 1) div(:collection_one_hundred, css: '.collection-card', index: 99) div(:collection_one_hundred_plus_one, css: '.collection-card', index: 100) - div(:collection_one_hundred_plus_one_title, css: '.collection-card .collection-card-title', index: 100) + div( + :collection_one_hundred_plus_one_title, + css: '.collection-card .collection-card-title', + index: 100) a(:collection_one_hundred_plus_one_owner, css: '.collection-card .collection-owner', index: 100) end -- To view, visit https://gerrit.wikimedia.org/r/237611 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1219dce4cb2f8ba3317d2865ead8f1881f8dcfab Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Gather Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits