jenkins-bot has submitted this change and it was merged.
Change subject: Avoid flashes: late debounce causes annoying flashes
......................................................................
Avoid flashes: late debounce causes annoying flashes
Validate elements are updated before replacing elements in the DOM.
Bug: T112168
Change-Id: Ia9556b0b9e9f5b0132be5a61a2cde7bb4dc5606e
---
M modules/ext.echo.init.js
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.echo.init.js b/modules/ext.echo.init.js
index 49db620..e372e2a 100644
--- a/modules/ext.echo.init.js
+++ b/modules/ext.echo.init.js
@@ -34,6 +34,8 @@
badgeIcon: 'speechBubble',
links: links
} );
+ // avoid late debouncedUpdateThemeClasses
+ mw.echo.ui.messageWidget.debouncedUpdateThemeClasses();
$existingMessageLink.replaceWith(
mw.echo.ui.messageWidget.$element );
}
@@ -48,6 +50,9 @@
},
links: links
} );
+
+ // avoid late debouncedUpdateThemeClasses
+ mw.echo.ui.alertWidget.debouncedUpdateThemeClasses();
$existingAlertLink.replaceWith( mw.echo.ui.alertWidget.$element
);
} );
--
To view, visit https://gerrit.wikimedia.org/r/237619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9556b0b9e9f5b0132be5a61a2cde7bb4dc5606e
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Eranroz <eranro...@gmail.com>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Quiddity <nwil...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
