Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/237892

Change subject: Undefined offset
......................................................................

Undefined offset

Change-Id: Ie8024f4b391d169234a76c0205a747df43ee5b1d
---
M DeletePagesForGood.class.php
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DeletePagesForGood 
refs/changes/92/237892/1

diff --git a/DeletePagesForGood.class.php b/DeletePagesForGood.class.php
index 628b0b2..ccca315 100644
--- a/DeletePagesForGood.class.php
+++ b/DeletePagesForGood.class.php
@@ -28,8 +28,11 @@
 
 
                #Special pages can not be deleted (special pages have no 
article id anyway).
-               if ( $wgTitle->getArticleID() != 0 && 
$wgDeletePagesForGoodNamespaces[$wgTitle->getNamespace()] == true && 
$wgTitle->getNamespace() != NS_SPECIAL ) {
-
+               if ( $wgTitle->getArticleID() != 0
+                       && isset( 
$wgDeletePagesForGoodNamespaces[$wgTitle->getNamespace()] )
+                       && 
$wgDeletePagesForGoodNamespaces[$wgTitle->getNamespace()] == true
+                       && $wgTitle->getNamespace() != NS_SPECIAL
+               ) {
                        $links['actions']['ask_delete_page_permanently'] = 
array(
                                'class' => ( $action == 
'ask_delete_page_permanently' ) ? 'selected' : false,
                                'text' => wfMessage( 
'deletepagesforgood-delete_permanently' )->text(),

-- 
To view, visit https://gerrit.wikimedia.org/r/237892
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8024f4b391d169234a76c0205a747df43ee5b1d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DeletePagesForGood
Gerrit-Branch: master
Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to