[MediaWiki-commits] [Gerrit] add to Special Page Group, minor cleanup - change (mediawiki...NewestPages)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: add to Special Page Group, minor cleanup
......................................................................


add to Special Page Group, minor cleanup

Change-Id: Iac21ff841e674fcbdb861c03422a5189a9481d32
---
M NewestPages.page.php
M NewestPages.php
2 files changed, 26 insertions(+), 17 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/NewestPages.page.php b/NewestPages.page.php
index 894760b..fa62ac2 100644
--- a/NewestPages.page.php
+++ b/NewestPages.page.php
@@ -55,7 +55,8 @@
                        $this->setHeaders();
                        $limit = $wgLang->formatNum( $this->limit );
                        if( $this->namespace > 0 ) {
-                               $wgOut->addWikiMsg( 'newestpages-ns-header', 
$limit, $wgContLang->getFormattedNsText( $this->namespace ) );
+                               $wgOut->addWikiMsg( 'newestpages-ns-header', 
$limit,
+                                       $wgContLang->getFormattedNsText( 
$this->namespace ) );
                        } else {
                                $wgOut->addWikiMsg( 'newestpages-header', 
$limit );
                        }
@@ -133,9 +134,10 @@
                        $link = $row->page_is_redirect
                                        ? '<span class="allpagesredirect">' . 
Linker::linkKnown( $title ) . '</span>'
                                        : Linker::linkKnown( $title );
-                       return( "<li>{$link}</li>\n" );
+                       return "<li>{$link}</li>\n";
                } else {
-                       return( "<!-- Invalid title " . htmlspecialchars( 
$row->page_title ) . " in namespace " . htmlspecialchars( $row->page_namespace 
) . " -->\n" );
+                       return "<!-- Invalid title " . htmlspecialchars( 
$row->page_title ) .
+                               " in namespace " . htmlspecialchars( 
$row->page_namespace ) . " -->\n";
                }
        }
 
@@ -151,11 +153,13 @@
                                $links[] = (string)$limit;
                        }
                }
-               return( $this->msg( 'newestpages-limitlinks' )->rawParams( 
$wgLang->pipeList( $links ) )->escaped() );
+               return $this->msg( 'newestpages-limitlinks' )->rawParams(
+                               $wgLang->pipeList( $links ) )->escaped();
        }
 
        function makeRedirectToggle() {
-               $label = $this->msg( $this->redirects ? 'newestpages-hideredir' 
: 'newestpages-showredir' )->escaped();
+               $label = $this->msg(
+                               $this->redirects ? 'newestpages-hideredir' : 
'newestpages-showredir'  )->escaped();
                return $this->makeSelfLink( $label, 'redirects', 
(int)!$this->redirects );
        }
 
@@ -178,7 +182,8 @@
 
        function makeNamespaceForm() {
                $self = $this->getPageTitle();
-               $form  = Xml::openElement( 'form', array( 'method' => 'post', 
'action' => $self->getLocalUrl() ) );
+               $form = Xml::openElement(
+                               'form', array( 'method' => 'post', 'action' => 
$self->getLocalUrl() ) );
                $form .= Xml::label( $this->msg( 'newestpages-namespace' 
)->text(), 'namespace' ) . '&#160;';
                $form .= Html::namespaceSelector( array(
                        'selected' => $this->namespace,
@@ -194,4 +199,8 @@
                $form .= Xml::submitButton( $this->msg( 'newestpages-submit' 
)->text() ) . '</form>';
                return $form;
        }
+
+       protected function getGroupName() {
+               return 'changes';
+       }
 }
diff --git a/NewestPages.php b/NewestPages.php
index cf0ccfc..63cdd45 100644
--- a/NewestPages.php
+++ b/NewestPages.php
@@ -1,6 +1,7 @@
 <?php
-if ( ! defined( 'MEDIAWIKI' ) )
-    die();
+if ( !defined( 'MEDIAWIKI' ) ) {
+       die();
+}
 
 /**
  * Special page to show the last X pages added to the wiki
@@ -14,19 +15,18 @@
  */
 
 $wgExtensionCredits['specialpage'][] = array(
-       'path'           => __FILE__,
-       'name'           => 'Newest Pages',
-       'version'        => '1.10.0',
-       'author'         => 'Rob Church',
-       'url'            => 
'https://www.mediawiki.org/wiki/Extension:Newest_Pages',
+       'path' => __FILE__,
+       'name' => 'Newest Pages',
+       'version' => '1.10.1',
+       'author' => 'Rob Church',
+       'url' => 'https://www.mediawiki.org/wiki/Extension:Newest_Pages',
        'descriptionmsg' => 'newestpages-desc',
 );
 
 $wgNewestPagesLimit = 50;
 
-$dir = dirname(__FILE__) . '/';
 $wgMessagesDirs['NewestPages'] = __DIR__ . '/i18n';
-$wgExtensionMessagesFiles['NewestPages'] = $dir . 'NewestPages.i18n.php';
-$wgExtensionMessagesFiles['NewestPagesAlias'] = $dir . 'NewestPages.alias.php';
-$wgAutoloadClasses['NewestPages'] = $dir . 'NewestPages.page.php';
+$wgExtensionMessagesFiles['NewestPages'] = __DIR__ . '/NewestPages.i18n.php';
+$wgExtensionMessagesFiles['NewestPagesAlias'] = __DIR__ . 
'/NewestPages.alias.php';
+$wgAutoloadClasses['NewestPages'] = __DIR__ . '/NewestPages.page.php';
 $wgSpecialPages['NewestPages'] = 'NewestPages';

-- 
To view, visit https://gerrit.wikimedia.org/r/181781
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac21ff841e674fcbdb861c03422a5189a9481d32
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/NewestPages
Gerrit-Branch: master
Gerrit-Owner: tosfos <tos...@yahoo.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Mlawnik <marcin.sa...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: jenkins-bot <>
Gerrit-Reviewer: tosfos <tos...@yahoo.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits