jenkins-bot has submitted this change and it was merged.

Change subject: Fix docs for MappingConfigBuilder::buildStringField
......................................................................


Fix docs for MappingConfigBuilder::buildStringField

Fix typo, param order and type.

Change-Id: I105458a283b391d4524740d6e54cb69996565f8c
---
M includes/Maintenance/MappingConfigBuilder.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  DCausse: Looks good to me, approved
  jenkins-bot: Verified

Objections:
  Cindy-the-browser-test-bot: There's a problem with this change, please improve



diff --git a/includes/Maintenance/MappingConfigBuilder.php 
b/includes/Maintenance/MappingConfigBuilder.php
index 9260e2f..7717c18 100644
--- a/includes/Maintenance/MappingConfigBuilder.php
+++ b/includes/Maintenance/MappingConfigBuilder.php
@@ -250,13 +250,13 @@
 
        /**
         * Build a string field that does standard analysis for the language.
-        * @param array|null $extra Extra analyzers for this field beyond the 
basic text and plain.
         * @param int $options Field options:
-        *   ENABLE_NORMS: Gnable norms on the field.  Good for text you search 
against but bad for array fields and useless
+        *   ENABLE_NORMS: Enable norms on the field.  Good for text you search 
against but bad for array fields and useless
         *     for fields that don't get involved in the score.
         *   COPY_TO_SUGGEST: Copy the contents of this field to the suggest 
field for "Did you mean".
         *   SPEED_UP_HIGHLIGHTING: Store extra data in the field to speed up 
highlighting.  This is important for long
         *     strings or fields with many values.
+        * @param array $extra Extra analyzers for this field beyond the basic 
text and plain.
         * @return array definition of the field
         */
        public function buildStringField( $options, $extra = array() ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/238072
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I105458a283b391d4524740d6e54cb69996565f8c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Cindy-the-browser-test-bot <bernhardsone...@gmail.com>
Gerrit-Reviewer: DCausse <dcau...@wikimedia.org>
Gerrit-Reviewer: EBernhardson <ebernhard...@wikimedia.org>
Gerrit-Reviewer: Manybubbles <never...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to