Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/238136
Change subject: Fix sequencing of logged session events in ShareHandler.
......................................................................
Fix sequencing of logged session events in ShareHandler.
In looking at the data from ShareAFactFunnel, I noticed that the session
ID always changes between the "highlight" and "sharetap" events, which
breaks the expected continuity between these events.
This fixes it so that the session ID remains constant between the
"highlight" and "sharetap" events.
Change-Id: I78e1ec3e2ba021037811385295f546b7f029c303
---
M app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/36/238136/1
diff --git a/app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
b/app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
index 721b456..c683371 100755
--- a/app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
+++ b/app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
@@ -77,7 +77,9 @@
String purpose = messagePayload.optString("purpose", "");
String text = messagePayload.optString("text", "");
if (purpose.equals("share")) {
- createFunnel();
+ if (funnel == null) {
+ createFunnel();
+ }
shareSnippet(text);
funnel.logShareTap(text);
}
--
To view, visit https://gerrit.wikimedia.org/r/238136
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78e1ec3e2ba021037811385295f546b7f029c303
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
