Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/238150
Change subject: Fix sharing of links in Gingerbread.
......................................................................
Fix sharing of links in Gingerbread.
Our method of removing "blacklisted" intents from the system-provided
intent chooser doesn't seem to work in GB. It's supposed to work by
initializing the chooser with one of the actual intents that will handle
the link sharing, and then adding the rest of the intents using the
EXTRA_INITIAL_INTENTS parameter. Neither of these things seems to have any
effect in GB.
Therefore, in GB, we'll just show the chooser with the blacklisted intents
included (a tradeoff we can live with).
Bug: T111583
Change-Id: Idaedfcbe1f9e576f8a79c3a44bfe78a6034dc8fb
---
M app/src/main/java/org/wikipedia/util/ShareUtils.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/50/238150/1
diff --git a/app/src/main/java/org/wikipedia/util/ShareUtils.java
b/app/src/main/java/org/wikipedia/util/ShareUtils.java
index b4262e7..3b5a642 100644
--- a/app/src/main/java/org/wikipedia/util/ShareUtils.java
+++ b/app/src/main/java/org/wikipedia/util/ShareUtils.java
@@ -179,7 +179,7 @@
return null;
}
- Intent bestIntent = intents.remove(0);
+ Intent bestIntent = ApiUtil.hasHoneyComb() ? intents.remove(0) :
targetIntent;
return Intent.createChooser(bestIntent, chooserTitle)
.putExtra(Intent.EXTRA_INITIAL_INTENTS, intents.toArray(new
Parcelable[intents.size()]));
}
--
To view, visit https://gerrit.wikimedia.org/r/238150
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idaedfcbe1f9e576f8a79c3a44bfe78a6034dc8fb
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
