jenkins-bot has submitted this change and it was merged.
Change subject: Removed clearSharedCache() hack in User.php
......................................................................
Removed clearSharedCache() hack in User.php
* WAN cache key salting/tombstones makes this overkill now
Change-Id: I078daacc5d2987858d720677f11e9828d71021e2
---
M includes/User.php
1 file changed, 0 insertions(+), 8 deletions(-)
Approvals:
Gilles: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/User.php b/includes/User.php
index 605dab6..dbcbe31 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -3709,14 +3709,6 @@
Hooks::run( 'UserSaveSettings', array( $this ) );
$this->clearSharedCache();
$this->getUserPage()->invalidateCache();
-
- // T95839: clear the cache again post-commit to reduce race
conditions
- // where stale values are written back to the cache by other
threads.
- // Note: this *still* doesn't deal with REPEATABLE-READ
snapshot lag...
- $that = $this;
- $dbw->onTransactionIdle( function() use ( $that ) {
- $that->clearSharedCache();
- } );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/236995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I078daacc5d2987858d720677f11e9828d71021e2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Gilles <gdu...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
