Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/238653
Change subject: Position the banner when banner is cached
......................................................................
Position the banner when banner is cached
The load event may have already fired when this code has run to ensure we run
twice
for the cached instance.
Change-Id: I3cd7566edbb630f18beff2d3c1a4512a05cea5ca
---
M
resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
1 file changed, 2 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/53/238653/1
diff --git
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
index 4354935..9e3c217 100644
---
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
+++
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
@@ -72,6 +72,8 @@
$( 'img.wpb-banner-image' ).load( function() {
positionBanner( $wpbBannerImageContainer );
} );
+ // Image might be cached
+ positionBanner( $wpbBannerImageContainer );
// Expose interface for testing.
mw.wpb = {
positionBanner: positionBanner
--
To view, visit https://gerrit.wikimedia.org/r/238653
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cd7566edbb630f18beff2d3c1a4512a05cea5ca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
