Ori.livneh has submitted this change and it was merged. Change subject: monolog: Don't waste milliseconds counting microseconds ......................................................................
monolog: Don't waste milliseconds counting microseconds Monolog makes an unwise trade here, sacrificing the performance of a very hot code path so that its timestamp have microsecond rather than millisecond accuracy. I am not optimistic about this getting merged upstream, so I'm comitting it as a local hack for now. Change-Id: Iccfda476892b3d9640a323d05ad9c5cd6aa04001 --- M monolog/monolog/src/Monolog/Logger.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori.livneh: Verified; Looks good to me, approved diff --git a/monolog/monolog/src/Monolog/Logger.php b/monolog/monolog/src/Monolog/Logger.php index 32e3dd9..671cd4c 100644 --- a/monolog/monolog/src/Monolog/Logger.php +++ b/monolog/monolog/src/Monolog/Logger.php @@ -258,7 +258,7 @@ 'level' => $level, 'level_name' => $levelName, 'channel' => $this->name, - 'datetime' => \DateTime::createFromFormat('U.u', sprintf('%.6F', microtime(true)), static::$timezone)->setTimezone(static::$timezone), + 'datetime' => new \DateTime(null, static::$timezone), 'extra' => array(), ); -- To view, visit https://gerrit.wikimedia.org/r/238669 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccfda476892b3d9640a323d05ad9c5cd6aa04001 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/vendor Gerrit-Branch: wmf/1.26wmf23 Gerrit-Owner: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits