Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238724
Change subject: Simplification in ClaimDifference ...................................................................... Simplification in ClaimDifference Change-Id: Idb37936df7afae8b0036c47cec8f254e79416549 --- M repo/includes/Diff/ClaimDifference.php 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/24/238724/1 diff --git a/repo/includes/Diff/ClaimDifference.php b/repo/includes/Diff/ClaimDifference.php index 8ec2e4e..407295a 100644 --- a/repo/includes/Diff/ClaimDifference.php +++ b/repo/includes/Diff/ClaimDifference.php @@ -121,9 +121,8 @@ } return $this->mainSnakChange == $target->mainSnakChange - // FIXME: Use Diff::equals when released. - && $this->getQualifierChanges()->getArrayCopy() == $target->getQualifierChanges()->getArrayCopy() - && $this->getReferenceChanges()->getArrayCopy() == $target->getReferenceChanges()->getArrayCopy() + && $this->getQualifierChanges()->equals( $target->getQualifierChanges() ) + && $this->getReferenceChanges()->equals( $target->getReferenceChanges() ) && $this->rankChange == $target->rankChange; } -- To view, visit https://gerrit.wikimedia.org/r/238724 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idb37936df7afae8b0036c47cec8f254e79416549 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits