Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/239044
Change subject: WIP Extract colordiff to contint::packages::colordiff ...................................................................... WIP Extract colordiff to contint::packages::colordiff Not sure where to include contint::packages::colordiff so it is applied to Nodepool instances. Bug: T112821 Change-Id: I3834dd4fb43245e34d71739b680f7b5b235265a6 --- M modules/contint/manifests/packages.pp A modules/contint/manifests/packages/colordiff.pp 2 files changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/44/239044/1 diff --git a/modules/contint/manifests/packages.pp b/modules/contint/manifests/packages.pp index c866278..f94f871 100644 --- a/modules/contint/manifests/packages.pp +++ b/modules/contint/manifests/packages.pp @@ -150,9 +150,7 @@ # Colordiff gives us nice coloring in Jenkins console whenever # it is used instead of the stock diff. - package { 'colordiff': - ensure => present, - } + include contint::packages::colordiff # JSDuck was built for Ubuntu ( T48236/ T82278 ) # It is a pain to rebuild for Jessie so give up (T95008), we will use diff --git a/modules/contint/manifests/packages/colordiff.pp b/modules/contint/manifests/packages/colordiff.pp new file mode 100644 index 0000000..2030c73 --- /dev/null +++ b/modules/contint/manifests/packages/colordiff.pp @@ -0,0 +1,10 @@ +# === Class contint::packages::colordiff +# +# Colordiff gives us nice coloring in Jenkins console whenever +# it is used instead of the stock diff. +# +class contint::packages::colordiff { + package { 'colordiff': + ensure => present, + } +} -- To view, visit https://gerrit.wikimedia.org/r/239044 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3834dd4fb43245e34d71739b680f7b5b235265a6 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits