Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/239101
Change subject: Rename two createLink methods to disambiguate
......................................................................
Rename two createLink methods to disambiguate
Change-Id: If2b6c525b1fbd38bba1d3067464613a85e395daa
---
M modules/tools/ext.cx.tools.link.js
1 file changed, 9 insertions(+), 9 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/01/239101/1
diff --git a/modules/tools/ext.cx.tools.link.js
b/modules/tools/ext.cx.tools.link.js
index b14d135..adcd3f6 100644
--- a/modules/tools/ext.cx.tools.link.js
+++ b/modules/tools/ext.cx.tools.link.js
@@ -241,7 +241,7 @@
selection = mw.cx.selection.get();
// Is this selection valid and editable?
if ( isValidSelection( selection ) ) {
- this.$link = this.createLink();
+ this.$link = this.createLinkFromLink();
} else {
return;
}
@@ -284,7 +284,7 @@
/**
* Convert a current selection if present, if editable to a link
*/
- CXLink.prototype.createLink = function () {
+ CXLink.prototype.createLinkFromLink = function () {
var $link, selection;
// Restore the selection
@@ -576,7 +576,7 @@
selection = mw.cx.selection.get();
// Is this selection valid and editable?
if ( isValidSelection( selection ) ) {
- self.createLink();
+ self.createLinkFromLink();
}
// Avoid bubbling. This can bubble to a translation
section focus and
@@ -649,7 +649,7 @@
.addClass( 'card__add-link' )
.text( mw.msg( 'cx-tools-link-add' ) )
.on( 'click', function () {
- self.createLink();
+ self.createLinkFromLink();
// Avoid bubbling
return false;
} );
@@ -969,7 +969,7 @@
api: mw.cx.siteMapper.getApi( mw.cx.targetLanguage ),
showMissingPage: true,
onSelect: function ( selectedPage ) {
- self.createLink( selectedPage, 'internal' );
+ self.createLinkWithTool( selectedPage,
'internal' );
}
} );
@@ -981,7 +981,7 @@
* @param {String} target Target title
* @param {type} type Link type: 'external' or 'internal'
*/
- LinkerTool.prototype.createLink = function ( target, type ) {
+ LinkerTool.prototype.createLinkWithTool = function ( target, type ) {
var $link;
if ( type === 'internal' ) {
@@ -1073,7 +1073,7 @@
} ).on( 'keypress', function ( e ) {
if ( e.which === 13 ) {
if ( linkType === 'external' ) {
- self.createLink(
self.$externalLinkInput.val(), linkType );
+ self.createLinkWithTool(
self.$externalLinkInput.val(), linkType );
}
// TODO: Add internal link also on enter
keypress.
}
@@ -1096,9 +1096,9 @@
this.$pageSelectorButton.on( 'click', function () {
if ( linkType === 'internal' ) {
- self.createLink(
self.$targetPageSelector.getSelectedPage(), linkType );
+ self.createLinkWithTool(
self.$targetPageSelector.getSelectedPage(), linkType );
} else {
- self.createLink( self.$externalLinkInput.val(),
linkType );
+ self.createLinkWithTool(
self.$externalLinkInput.val(), linkType );
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/239101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2b6c525b1fbd38bba1d3067464613a85e395daa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
