jenkins-bot has submitted this change and it was merged.
Change subject: Remove use of no longer existing $wgUseDumbLinkUpdate variable
......................................................................
Remove use of no longer existing $wgUseDumbLinkUpdate variable
$wgUseDumbLinkUpdate and LinksUpdate::doDumbUpdate were
removed from MediaWiki in 1.22: I115f8cf9
Change-Id: I9fcc92b241db4605c9c8799747d539243e5ade5e
---
M WikilogLinksUpdate.php
1 file changed, 2 insertions(+), 24 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WikilogLinksUpdate.php b/WikilogLinksUpdate.php
index e5af28c..2b8bfc0 100644
--- a/WikilogLinksUpdate.php
+++ b/WikilogLinksUpdate.php
@@ -47,17 +47,7 @@
$this->mTags = $parserOutput->getTags();
}
- function doUpdate() {
- global $wgUseDumbLinkUpdate;
-
- if ( $wgUseDumbLinkUpdate ) {
- $this->doDumbUpdate();
- } else {
- $this->doIncrementalUpdate();
- }
- }
-
- private function doIncrementalUpdate() {
+ public function doUpdate() {
# Authors
$existing = $this->getExistingAuthors();
$this->incrTableUpdate( 'wikilog_authors',
@@ -75,18 +65,6 @@
);
}
- private function doDumbUpdate() {
- $this->dumbTableUpdate( 'wikilog_authors', 'wla_page',
$this->getAuthorInsertions() );
- $this->dumbTableUpdate( 'wikilog_tags', 'wlt_page',
$this->getTagInsertions() );
- }
-
- private function dumbTableUpdate( $table, $from, $insertions ) {
- $this->mDb->delete( $table, array( $from => $this->mId ),
__METHOD__ );
- if ( count( $insertions ) ) {
- $this->mDb->insert( $table, $insertions, __METHOD__,
'IGNORE' );
- }
- }
-
private function incrTableUpdate( $table, $from, $to, $deletions,
$insertions ) {
if ( count( $deletions ) ) {
$where = array(
@@ -99,7 +77,7 @@
$this->mDb->insert( $table, $insertions, __METHOD__,
'IGNORE' );
}
}
-
+
private function getAuthorInsertions( $existing = array() ) {
$arr = array();
$diffs = array_diff_key( $this->mAuthors, $existing );
--
To view, visit https://gerrit.wikimedia.org/r/239144
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fcc92b241db4605c9c8799747d539243e5ade5e
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Wikilog
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
