[MediaWiki-commits] [Gerrit] Make ConstraintParameterParserTest work for non-english wikis - change (mediawiki...WikibaseQualityConstraints)

[Aude (Code Review)]

Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/239358

Change subject: Make ConstraintParameterParserTest work for non-english wikis
......................................................................

Make ConstraintParameterParserTest work for non-english wikis

Otherwise I get failures like:

1) 
WikibaseQuality\ConstraintReport\Test\Helper\ConstraintParameterParserTest::testParseNullParameter
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'none'
+    0 => 'ninguno'
 )

Change-Id: Id6242e39d3aaf117cbd821c0d0b5c3d3d858cb11
---
M tests/phpunit/Helper/ConstraintParameterParserTest.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
 refs/changes/58/239358/1

diff --git a/tests/phpunit/Helper/ConstraintParameterParserTest.php 
b/tests/phpunit/Helper/ConstraintParameterParserTest.php
index 096afee..50f5aee 100644
--- a/tests/phpunit/Helper/ConstraintParameterParserTest.php
+++ b/tests/phpunit/Helper/ConstraintParameterParserTest.php
@@ -14,7 +14,7 @@
  * @author BP2014N1
  * @license GNU GPL v2+
  */
-class ConstraintParameterParserTest extends \MediaWikiTestCase {
+class ConstraintParameterParserTest extends \MediaWikiLangTestCase {
 
        private $helper;
 
@@ -84,4 +84,4 @@
                $parameter = 'R1';
                $this->assertEquals( array ( '' ), 
$this->helper->parseSingleParameter( $parameter ) );
        }
-}
\ No newline at end of file
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/239358
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6242e39d3aaf117cbd821c0d0b5c3d3d858cb11
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits