jenkins-bot has submitted this change and it was merged.
Change subject: Do not double load gallery styles now cache has expired
......................................................................
Do not double load gallery styles now cache has expired
Was separated in 1.26wmf21 (Ib1aef04dc4fece78e6615386ecaef6a9f368f49e)
We should aim to get this in 1.26wmf24 (there will still
be a small amount of pages with outdated HTML but the benefit
to all users not double loading is arguably larger at this point)
Bug: T110709
Change-Id: I96acc21f57ecc8c5e55df9528a4412d0ea641fa8
---
M resources/Resources.php
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/Resources.php b/resources/Resources.php
index 07142a5..4e59312 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1759,8 +1759,6 @@
'mediawiki.legacy.commonPrint' => array(
'position' => 'top',
'styles' => array(
- // @todo: Remove mediawiki.page.gallery when cache has
cleared
-
'resources/src/mediawiki.page/mediawiki.page.gallery.print.css' => array(
'media' => 'print' ),
// @todo: Remove
mediawiki.action.view.filepage.print.css when cache has cleared
'resources/src/mediawiki.action/mediawiki.action.view.filepage.print.css' =>
array( 'media' => 'print' ),
'resources/src/mediawiki.legacy/commonPrint.css' =>
array( 'media' => 'print' )
@@ -1775,8 +1773,6 @@
'mediawiki.legacy.shared' => array(
'position' => 'top',
'styles' => array(
- // @todo: Remove when mediawiki.page.gallery in cached
html.
-
'resources/src/mediawiki.page/mediawiki.page.gallery.css',
// @todo: Remove mediawiki.action.view.filepage.css
// and mediawiki.legacy/images/checker.png when cache
has cleared
'resources/src/mediawiki.action/mediawiki.action.view.filepage.css',
--
To view, visit https://gerrit.wikimedia.org/r/233085
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96acc21f57ecc8c5e55df9528a4412d0ea641fa8
Gerrit-PatchSet: 10
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
