Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/239852

Change subject: Remove some dead code related to jQuery UI buttons
......................................................................

Remove some dead code related to jQuery UI buttons

* uw.ui.Wizard.js
  * The selector matches nothing, all buttons are generated
    with OOjs UI (and use <a> tags rather than <button>, which
    is why this did not break horribly so far, it was a no-op).
* uploadWizard.css
  * Again, there are no <button> elements there at all.
  * .ui-button is a jQuery UI class.

Change-Id: Ia1da141a84178544343636b41c3e58b7f6ce746a
---
M resources/ui/uw.ui.Wizard.js
M resources/uploadWizard.css
2 files changed, 0 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard 
refs/changes/52/239852/1

diff --git a/resources/ui/uw.ui.Wizard.js b/resources/ui/uw.ui.Wizard.js
index fa64668..f2a330c 100644
--- a/resources/ui/uw.ui.Wizard.js
+++ b/resources/ui/uw.ui.Wizard.js
@@ -29,8 +29,6 @@
                this.wizard = wizard;
 
                this.initHeader( mw.UploadWizard.config );
-
-               this.initButtons();
        };
 
        OO.mixinClass( uw.ui.Wizard, OO.EventEmitter );
@@ -133,16 +131,6 @@
                        .addClass( 'ui-helper-clearfix ui-state-default 
ui-widget ui-helper-reset ui-helper-clearfix' )
                        .arrowSteps()
                        .show();
-       };
-
-       /**
-        * Initialize all of the buttons in the interface.
-        */
-       uw.ui.Wizard.prototype.initButtons = function () {
-               // make all stepdiv proceed buttons into jquery buttons
-               $( '.mwe-upwiz-stepdiv .mwe-upwiz-buttons button' )
-                       .button()
-                       .css( { 'margin-left': '1em' } );
        };
 
 }( mediaWiki, jQuery, mediaWiki.uploadWizard, OO ) );
diff --git a/resources/uploadWizard.css b/resources/uploadWizard.css
index 52153af..f09fda6 100644
--- a/resources/uploadWizard.css
+++ b/resources/uploadWizard.css
@@ -305,10 +305,6 @@
        margin-top: 1em;
 }
 
-#mwe-upwiz-upload-ctrls button, .mwe-upwiz-buttons button {
-       font-size: 1em;
-}
-
 #mwe-upwiz-stepdiv-file .mwe-upwiz-buttons {
        display: none;
 }
@@ -707,11 +703,6 @@
 .mwe-upwiz-hint:hover {
     /* @embed */
     background: url('images/question-hover.png') no-repeat;
-}
-
-/* Hack for Explorer 6 and 7 - line up buttons with other content */
-.mwe-upwiz-buttons .ui-button, .cat-widget .ui-button {
-       *vertical-align: middle;
 }
 
 #upload-wizard .ui-corner-tl {

-- 
To view, visit https://gerrit.wikimedia.org/r/239852
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1da141a84178544343636b41c3e58b7f6ce746a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to