jenkins-bot has submitted this change and it was merged.
Change subject: Make save dialog variable height
......................................................................
Make save dialog variable height
Change-Id: I90437b3130d08441e5c93b2a34fd9083106a14b3
---
M modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Alex Monk: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
index 112baba..5c7ce0f 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
@@ -212,6 +212,7 @@
dialog.$reviewEditSummary.parent().addClass( 'oo-ui-element-hidden' );
} ).always( function () {
dialog.$reviewEditSummary.parent().removeClass( 'mw-ajax-loader' );
+ dialog.updateSize();
} );
}
}
@@ -223,6 +224,7 @@
// Show the target panel
this.panels.setItem( panelObj );
+ this.updateSize();
mw.hook( 've.saveDialog.stateChanged' ).fire();
@@ -343,6 +345,7 @@
// Properties
this.panels = new OO.ui.StackLayout( { scrollable: true } );
this.savePanel = new OO.ui.PanelLayout( {
+ expanded: false,
scrollable: true,
padded: true,
classes: [ 've-ui-mwSaveDialog-savePanel' ]
@@ -408,6 +411,7 @@
// Review panel
this.reviewPanel = new OO.ui.PanelLayout( {
+ expanded: false,
scrollable: true,
padded: true
} );
@@ -425,6 +429,7 @@
// Conflict panel
this.conflictPanel = new OO.ui.PanelLayout( {
+ expanded: false,
scrollable: true,
padded: true
} );
@@ -435,6 +440,7 @@
// No changes panel
this.nochangesPanel = new OO.ui.PanelLayout( {
+ expanded: false,
scrollable: true,
padded: true
} );
@@ -547,7 +553,7 @@
*/
ve.ui.MWSaveDialog.prototype.getBodyHeight = function () {
// Don't vary the height when the foot is made visible or not
- return 350 - this.$foot.outerHeight( true );
+ return this.panels.getCurrentItem().$element.outerHeight( true );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/239879
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90437b3130d08441e5c93b2a34fd9083106a14b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
