jenkins-bot has submitted this change and it was merged.
Change subject: Add navigation drawer shadow
......................................................................
Add navigation drawer shadow
Add a soft subtle shadow to the navigation drawer for consistent
appearance on API 15 and 23. No changes to scrim.
Bug: T107338
Change-Id: Ib58c20fcca821fe1afe450cb2c8d0ffd60af4440
---
M app/src/main/java/org/wikipedia/page/PageActivity.java
M app/src/main/res/drawable/nav_drawer_shadow.xml
2 files changed, 8 insertions(+), 4 deletions(-)
Approvals:
Mholloway: Looks good to me, but someone else must approve
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/page/PageActivity.java
b/app/src/main/java/org/wikipedia/page/PageActivity.java
index e24226f..73bb990 100644
--- a/app/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/app/src/main/java/org/wikipedia/page/PageActivity.java
@@ -210,6 +210,9 @@
updateProgressBar(false, true, 0);
drawerLayout = (WikiDrawerLayout) findViewById(R.id.drawer_layout);
+ if (!ApiUtil.hasLollipop()) {
+ drawerLayout.setDrawerShadow(R.drawable.nav_drawer_shadow,
GravityCompat.START);
+ }
navDrawer = (NavigationView) findViewById(R.id.navdrawer);
navMenu = navDrawer.getMenu();
navDrawerHelper = new NavDrawerHelper(this);
diff --git a/app/src/main/res/drawable/nav_drawer_shadow.xml
b/app/src/main/res/drawable/nav_drawer_shadow.xml
index 8907bde..3d05f54 100644
--- a/app/src/main/res/drawable/nav_drawer_shadow.xml
+++ b/app/src/main/res/drawable/nav_drawer_shadow.xml
@@ -1,8 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
-<shape xmlns:android="http://schemas.android.com/apk/res/android";
- android:shape="rectangle">
+<shape xmlns:android="http://schemas.android.com/apk/res/android";>
<gradient
- android:startColor="#60000000"
- android:endColor="#00000000"
+ android:startColor="#6000"
+ android:endColor="@android:color/transparent"
android:angle="0"/>
+
+ <size android:width="4dp" />
</shape>
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/239517
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib58c20fcca821fe1afe450cb2c8d0ffd60af4440
Gerrit-PatchSet: 3
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
