jenkins-bot has submitted this change and it was merged.
Change subject: Add debug info to OptInController
......................................................................
Add debug info to OptInController
This should help me track what happens when enabling/disabling.
Bug: T112784
Change-Id: I8add10863a99849efebd7bea4ea8ed9cf241810d
---
M includes/Import/OptInController.php
1 file changed, 19 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Import/OptInController.php
b/includes/Import/OptInController.php
index d979c70..73b884d 100644
--- a/includes/Import/OptInController.php
+++ b/includes/Import/OptInController.php
@@ -73,22 +73,30 @@
return;
}
+ wfDebugLog( 'Flow', __METHOD__ . ': start' );
+
// archive existing wikitext talk page
$linkToArchivedTalkpage = null;
if ( $title->exists( Title::GAID_FOR_UPDATE ) ) {
$wikitextTalkpageArchiveTitle =
$this->archiveExistingTalkpage( $title );
+ wfDebugLog( 'Flow', __METHOD__ . ': archived existing
talk page ' . $title->getPrefixedDBkey() . '(' . $title->getArticleID() . ') to
' . $wikitextTalkpageArchiveTitle->getPrefixedDBkey() . '(' .
$wikitextTalkpageArchiveTitle->getArticleID() . ')' );
$this->addArchiveTemplate(
$wikitextTalkpageArchiveTitle, $title );
$linkToArchivedTalkpage =
$this->buildLinkToArchivedTalkpage( $wikitextTalkpageArchiveTitle );
+ wfDebugLog( 'Flow', __METHOD__ . ': link to archived
page: ' . $linkToArchivedTalkpage );
}
// create or restore flow board
$archivedFlowPage = $this->findLatestFlowArchive( $title );
if ( $archivedFlowPage ) {
$this->restoreExistingFlowBoard( $archivedFlowPage,
$title, $linkToArchivedTalkpage );
+ wfDebugLog( 'Flow', __METHOD__ . ': restored existing
Flow board ' . $archivedFlowPage->getPrefixedDBkey() . ' (' .
$archivedFlowPage->getArticleID() . ') to ' . $title->getPrefixedDBkey() . '('
. $title->getArticleID() . ')' );
} else {
$this->createFlowBoard( $title, $linkToArchivedTalkpage
);
+ wfDebugLog( 'Flow', __METHOD__ . ': created new Flow
board: ' . $title->getPrefixedDBkey() . ' (' . $title->getArticleID() . ')' );
$this->notificationController->notifyFlowEnabledOnTalkpage( $user );
}
+
+ wfDebugLog( 'Flow', __METHOD__ . ': done' );
}
/**
@@ -99,17 +107,23 @@
return;
}
+ wfDebugLog( 'Flow', __METHOD__ . ': start' );
+
// archive the flow board
$flowArchiveTitle = $this->findNextFlowArchive( $title );
$this->movePage( $title, $flowArchiveTitle );
+ wfDebugLog( 'Flow', __METHOD__ . ': archived existing Flow
board ' . $title->getPrefixedDBkey() . '(' . $title->getArticleID() . ') to ' .
$flowArchiveTitle->getPrefixedDBkey() . '(' . $flowArchiveTitle->getArticleID()
. ')' );
$this->removeArchivedTalkpageTemplateFromFlowBoardDescription(
$flowArchiveTitle );
// restore the original wikitext talk page
$archivedTalkpage = $this->findLatestArchive( $title );
if ( $archivedTalkpage ) {
$this->movePage( $archivedTalkpage, $title );
+ wfDebugLog( 'Flow', __METHOD__ . ': restored existing
talk page ' . $archivedTalkpage->getPrefixedDBkey() . '(' .
$archivedTalkpage->getArticleID() . ') to ' . $title->getPrefixedDBkey() . '('
. $title->getArticleID() . ')' );
$this->removeArchiveTemplateFromWikitextTalkpage(
$title );
}
+
+ wfDebugLog( 'Flow', __METHOD__ . ': done' );
}
/**
@@ -316,6 +330,7 @@
$this->movePage( $archivedFlowPage, $title );
if ( $addToHeader ) {
+ wfDebugLog( 'Flow', __METHOD__ . ': adding to
description: ' . var_export( $addToHeader, true ) );
$this->editBoardDescription( $title, function( $oldDesc
) use ( $addToHeader ) {
return $oldDesc . "\n\n" . $addToHeader;
}, 'wikitext' );
@@ -417,9 +432,11 @@
* manually convert the content.
*/
$content = $revision->getContentRaw();
+ wfDebugLog( 'Flow', __METHOD__ . ': existing description: ' .
var_export( $content, true ) );
$content = Utils::convert( $revision->getContentFormat(),
$format, $content, $title );
$newDescription = call_user_func( $newDescriptionCallback,
$content );
+ wfDebugLog( 'Flow', __METHOD__ . ': new description: ' .
var_export( $newDescription, true ) );
$action = 'edit-header';
$params = array(
@@ -454,7 +471,8 @@
}
}
- $loader->commit( $blocksToCommit );
+ $result = $loader->commit( $blocksToCommit );
+ wfDebugLog( 'Flow', __METHOD__ . ': header committed: ' .
var_export( $result, true ) );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/240093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8add10863a99849efebd7bea4ea8ed9cf241810d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
