jenkins-bot has submitted this change and it was merged.
Change subject: build: Enable jscs jsDoc rule 'checkRedundantReturns' and make
pass
......................................................................
build: Enable jscs jsDoc rule 'checkRedundantReturns' and make pass
Change-Id: I5006ea3df6798201edfacbf8ad4624266554f064
---
M .jscsrc
M resources/src/jquery/jquery.suggestions.js
M resources/src/mediawiki.messagePoster/mediawiki.messagePoster.MessagePoster.js
M resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.js
M resources/src/mediawiki/mediawiki.htmlform.js
5 files changed, 7 insertions(+), 4 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.jscsrc b/.jscsrc
index aaa876c..46d98aa 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -7,6 +7,7 @@
"disallowQuotedKeysInObjects": "allButReserved",
"requireDotNotation": { "allExcept": [ "keywords" ] },
"jsDoc": {
+ "checkRedundantReturns": true,
"requireNewlineAfterDescription": true,
"requireParamTypes": true,
"requireReturnTypes": true
diff --git a/resources/src/jquery/jquery.suggestions.js
b/resources/src/jquery/jquery.suggestions.js
index dc1c779..4d53546 100644
--- a/resources/src/jquery/jquery.suggestions.js
+++ b/resources/src/jquery/jquery.suggestions.js
@@ -18,10 +18,11 @@
*
* @class jQuery.plugin.suggestions
*/
+
/**
* @method suggestions
- * @return {jQuery}
* @chainable
+ * @return {jQuery}
*
* @param {Object} options
*
@@ -92,6 +93,7 @@
* @param {boolean} [options.highlightInput=false] Whether to highlight
matched portions of the
* input or not.
*/
+
( function ( $ ) {
var hasOwn = Object.hasOwnProperty;
diff --git
a/resources/src/mediawiki.messagePoster/mediawiki.messagePoster.MessagePoster.js
b/resources/src/mediawiki.messagePoster/mediawiki.messagePoster.MessagePoster.js
index 91366ff..113fb00 100644
---
a/resources/src/mediawiki.messagePoster/mediawiki.messagePoster.MessagePoster.js
+++
b/resources/src/mediawiki.messagePoster/mediawiki.messagePoster.MessagePoster.js
@@ -16,6 +16,7 @@
/**
* Post a message (with subject and body) to a talk page.
*
+ * @abstract
* @param {string} subject Subject/topic title; plaintext only (no
wikitext or HTML)
* @param {string} body Body, as wikitext. Signature code will
automatically be added
* by MessagePosters that require one, unless the message already
contains the string
diff --git a/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.js
b/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.js
index 49acfef..9535481 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.js
@@ -152,7 +152,6 @@
* @param {string|null} [fade=null] Direction in which to fade out
current calendar contents,
* 'previous', 'next', 'up' or 'down'; or 'auto', which has the
same result as 'previous' or
* 'next' depending on whether the current date is later or earlier
than the previous.
- * @returns {string} Format
*/
mw.widgets.CalendarWidget.prototype.updateUI = function ( fade ) {
var items, today, selected, currentMonth, currentYear,
currentDay, i, needsFade,
diff --git a/resources/src/mediawiki/mediawiki.htmlform.js
b/resources/src/mediawiki/mediawiki.htmlform.js
index 8c6f3ab..c323e8d 100644
--- a/resources/src/mediawiki/mediawiki.htmlform.js
+++ b/resources/src/mediawiki/mediawiki.htmlform.js
@@ -222,11 +222,11 @@
* @param {Function} callback
* @param {boolean|jQuery.Event} callback.immediate True when the event
is called immediately,
* an event object when triggered from an event.
- * @return {jQuery}
* @chainable
+ * @return {jQuery}
*/
mw.log.deprecate( $.fn, 'liveAndTestAtStart', function ( callback ) {
- this
+ return this
// Can't really migrate to .on() generically, needs
knowledge of
// calling code to know the correct selector. Fix
callers and
// get rid of this .liveAndTestAtStart() hack.
--
To view, visit https://gerrit.wikimedia.org/r/236342
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5006ea3df6798201edfacbf8ad4624266554f064
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
