jenkins-bot has submitted this change and it was merged.

Change subject: Replicate browser test config for QuickSurveys
......................................................................


Replicate browser test config for QuickSurveys

Tests are currently failing on beta labs due to invalid configuration.

This replicates the config used in the extension's per-commit browser
tests rather than requiring it directly as it's unlikely to change, and
requiring files other than the extension's entry point seemed flawed.

Override the original config variable given its empty by default.

Bug: T112204
Change-Id: I23e4385ff18423e0a7cc11a6d9d9f50151681296
---
M wmf-config/CommonSettings-labs.php
1 file changed, 50 insertions(+), 15 deletions(-)

Approvals:
  Phuedx: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/CommonSettings-labs.php 
b/wmf-config/CommonSettings-labs.php
index 0ddb6f0..65071a6 100644
--- a/wmf-config/CommonSettings-labs.php
+++ b/wmf-config/CommonSettings-labs.php
@@ -233,22 +233,57 @@
 if ( $wmgUseQuickSurveys ) {
        wfLoadExtensions( array( 'QuickSurveys' ) );
 
-       $wgQuickSurveysConfig[] = array(
-               'name' => 'internal example survey',
-               'type' => 'internal',
-               'question' => 
'ext-quicksurveys-example-internal-survey-question',
-               'answers' => array(
-                       'positive' => 
'ext-quicksurveys-example-internal-survey-answer-positive',
-                       'neutral' => 
'ext-quicksurveys-example-internal-survey-answer-neutral',
-                       'negative' => 
'ext-quicksurveys-example-internal-survey-answer-negative',
+       $wgQuickSurveysConfig = array(
+               array(
+                       "name" => "drink-survey",
+                       "type" => "internal",
+                       "question" => "anne-survey-question",
+                       "answers" => array(
+                               "anne-survey-answer-one",
+                               "anne-survey-answer-two",
+                               "anne-survey-answer-three",
+                               "anne-survey-answer-four"
+                       ),
+                       "schema" => "QuickSurveysResponses",
+                       "enabled" => true,
+                       "coverage" => 0,
+                       "description" => "anne-survey-description",
+                       "platform" => array(
+                               "desktop" => array( "stable" ),
+                               "mobile" => array( "stable", "beta", "alpha" ),
+                       ),
                ),
-               'schema' => 'QuickSurveysResponses',
-               'enabled' => true,
-               'coverage' => .5,
-               'description' => 
'ext-quicksurveys-example-internal-survey-description',
-               'platform' => array(
-                       'desktop' => array( 'stable' ),
-                       'mobile' => array( 'stable', 'beta', 'alpha' ),
+               array(
+                       "name" => "internal example survey",
+                       "type" => "internal",
+                       "question" => 
"ext-quicksurveys-example-internal-survey-question",
+                       "answers" => array(
+                               
"ext-quicksurveys-example-internal-survey-answer-positive",
+                               
"ext-quicksurveys-example-internal-survey-answer-neutral",
+                               
"ext-quicksurveys-example-internal-survey-answer-negative",
+                       ),
+                       "schema" => "QuickSurveysResponses",
+                       "enabled" => true,
+                       "coverage" => .5,
+                       "description" => 
"ext-quicksurveys-example-internal-survey-description",
+                       "platform" => array(
+                               "desktop" => array( "stable" ),
+                               "mobile" => array( "stable", "beta", "alpha" ),
+                       ),
+               ),
+               array(
+                       'name' => 'external example survey',
+                       'type' => 'external',
+                       "question" => 
"ext-quicksurveys-example-external-survey-question",
+                       "description" => 
"ext-quicksurveys-example-external-survey-description",
+                       "link" => 
"ext-quicksurveys-example-external-survey-link",
+                       "privacyPolicy" => 
"ext-quicksurveys-example-external-survey-privacy-policy",
+                       'coverage' => .5,
+                       'enabled' => true,
+                       'platform' => array(
+                               'desktop' => array( 'stable' ),
+                               'mobile' => array( 'stable', 'beta', 'alpha' ),
+                       ),
                ),
        );
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/239158
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I23e4385ff18423e0a7cc11a6d9d9f50151681296
Gerrit-PatchSet: 5
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Phuedx <g...@samsmith.io>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to