jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused entityType parameter from views
......................................................................
Remove unused entityType parameter from views
This parameter hasn't been used in `claimview`s since
30e95d94554d319dfb183cc7ee2937b9eab3cb3a.
Change-Id: I2fe47b8a9e3e093d4b3909c2b0fa8300237df174
---
M view/resources/jquery/wikibase/jquery.wikibase.itemview.js
M view/resources/jquery/wikibase/jquery.wikibase.propertyview.js
M view/resources/jquery/wikibase/jquery.wikibase.statementgrouplistview.js
M view/resources/jquery/wikibase/jquery.wikibase.statementgroupview.js
4 files changed, 0 insertions(+), 10 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.itemview.js
b/view/resources/jquery/wikibase/jquery.wikibase.itemview.js
index 2d86045..8ff4902 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.itemview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.itemview.js
@@ -165,7 +165,6 @@
value: this.options.value.getStatements(),
claimGuidGenerator: claimGuidGenerator,
dataTypeStore: this.option( 'dataTypeStore' ),
- entityType: this.options.value.getType(),
entityStore: this.options.entityStore,
valueViewBuilder: this.options.valueViewBuilder,
entityChangersFactory:
this.options.entityChangersFactory
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.propertyview.js
b/view/resources/jquery/wikibase/jquery.wikibase.propertyview.js
index 2df4fdf..d597440 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.propertyview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.propertyview.js
@@ -105,7 +105,6 @@
value: this.options.value.getStatements(),
claimGuidGenerator: claimGuidGenerator,
dataTypeStore: this.option( 'dataTypeStore' ),
- entityType: this.options.value.getType(),
entityStore: this.options.entityStore,
valueViewBuilder: this.options.valueViewBuilder,
entityChangersFactory:
this.options.entityChangersFactory
diff --git
a/view/resources/jquery/wikibase/jquery.wikibase.statementgrouplistview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementgrouplistview.js
index 9fcf4c3..5f73e90 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementgrouplistview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementgrouplistview.js
@@ -23,8 +23,6 @@
* The `Statements` to be displayed by this view.
* @param {wikibase.utilities.ClaimGuidGenerator} options.claimGuidGenerator
* Required for dynamically generating GUIDs for new `Statement`s.
- * @param {string} [options.entityType=wikibase.datamodel.Item.TYPE]
- * Type of the `Entity` the `statementgrouplistview` refers to.
* @param {wikibase.store.EntityStore} options.entityStore
* Required for dynamically gathering `Entity`/`Property` information.
* @param {wikibase.ValueViewBuilder} options.valueViewBuilder
@@ -50,7 +48,6 @@
templateShortCuts: {},
value: null,
claimGuidGenerator: null,
- entityType: wb.datamodel.Item.TYPE,
entityStore: null,
valueViewBuilder: null,
entityChangersFactory: null,
@@ -127,7 +124,6 @@
return {
value: value,
claimGuidGenerator:
self.options.claimGuidGenerator,
- entityType:
self.options.entityType,
dataTypeStore:
self.options.dataTypeStore,
entityStore:
self.options.entityStore,
valueViewBuilder:
self.options.valueViewBuilder,
diff --git
a/view/resources/jquery/wikibase/jquery.wikibase.statementgroupview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementgroupview.js
index e1ab9d7..1973b83 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementgroupview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementgroupview.js
@@ -25,8 +25,6 @@
* "add" button to add new `Statements`.
* @param {wikibase.utilities.ClaimGuidGenerator} options.claimGuidGenerator
* Required for dynamically generating GUIDs for new `Statement`s.
- * @param {string} [entityType=wikibase.datamodel.Item.TYPE]
- * Type of the entity that the widget refers to.
* @param {wikibase.store.EntityStore} options.entityStore
* Required for dynamically gathering `Entity`/`Property` information.
* @param {wikibase.ValueViewBuilder} options.valueViewBuilder
@@ -63,7 +61,6 @@
},
value: null,
claimGuidGenerator: null,
- entityType: wb.datamodel.Item.TYPE,
entityStore: null,
valueViewBuilder: null,
entityChangersFactory: null,
@@ -174,7 +171,6 @@
? this.options.value.getItemContainer()
: new wb.datamodel.StatementList(),
claimGuidGenerator: self.options.claimGuidGenerator,
- entityType: self.options.entityType,
entityStore: self.options.entityStore,
valueViewBuilder: self.options.valueViewBuilder,
entityChangersFactory:
self.options.entityChangersFactory,
--
To view, visit https://gerrit.wikimedia.org/r/240313
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fe47b8a9e3e093d4b3909c2b0fa8300237df174
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
