Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/240662
Change subject: Fixed Style/TrailingComma RuboCop offense
......................................................................
Fixed Style/TrailingComma RuboCop offense
Bug: T106220
Change-Id: I7db5b10393376a6c11ba399abf13f18cb50365e9
---
M .rubocop_todo.yml
M Vagrantfile
M lib/mediawiki-vagrant/config.rb
M lib/mediawiki-vagrant/hiera.rb
M lib/mediawiki-vagrant/roles/change.rb
5 files changed, 5 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant
refs/changes/62/240662/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 278bfb5..d482b24 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -159,13 +159,3 @@
- 'lib/mediawiki-vagrant/config.rb'
- 'lib/mediawiki-vagrant/hiera.rb'
- 'lib/mediawiki-vagrant/lsb_check/config.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
-Style/TrailingComma:
- Exclude:
- - 'Vagrantfile'
- - 'lib/mediawiki-vagrant/config.rb'
- - 'lib/mediawiki-vagrant/hiera.rb'
- - 'lib/mediawiki-vagrant/roles/change.rb'
diff --git a/Vagrantfile b/Vagrantfile
index e5ae0f7..4905d9c 100644
--- a/Vagrantfile
+++ b/Vagrantfile
@@ -205,7 +205,7 @@
'--logdest', "/vagrant/logs/puppet/puppet.#{mwv.commit ||
'unknown'}.log",
'--logdest', 'console',
'--write-catalog-summary',
- '--detailed-exitcodes',
+ '--detailed-exitcodes'
]
# For more output, uncomment the following line:
@@ -219,7 +219,7 @@
'git_user' => settings[:git_user],
'forwarded_port' => settings[:http_port],
'shared_apt_cache' => '/vagrant/cache/apt/',
- 'environment' => ENV['MWV_ENVIRONMENT'] || 'vagrant',
+ 'environment' => ENV['MWV_ENVIRONMENT'] || 'vagrant'
}
if settings[:http_port] != 80
diff --git a/lib/mediawiki-vagrant/config.rb b/lib/mediawiki-vagrant/config.rb
index be5ddbf..3d41981 100644
--- a/lib/mediawiki-vagrant/config.rb
+++ b/lib/mediawiki-vagrant/config.rb
@@ -21,7 +21,7 @@
list: false,
required: false,
get: [],
- unset: [],
+ unset: []
}
opts = OptionParser.new do |o|
diff --git a/lib/mediawiki-vagrant/hiera.rb b/lib/mediawiki-vagrant/hiera.rb
index 65fb773..027a252 100644
--- a/lib/mediawiki-vagrant/hiera.rb
+++ b/lib/mediawiki-vagrant/hiera.rb
@@ -13,7 +13,7 @@
def execute
options = {
- unset: [],
+ unset: []
}
opts = OptionParser.new do |o|
diff --git a/lib/mediawiki-vagrant/roles/change.rb
b/lib/mediawiki-vagrant/roles/change.rb
index 0a372a8..57ba092 100644
--- a/lib/mediawiki-vagrant/roles/change.rb
+++ b/lib/mediawiki-vagrant/roles/change.rb
@@ -15,7 +15,7 @@
def execute
options = {
- provision: false,
+ provision: false
}
opts = OptionParser.new do |o|
--
To view, visit https://gerrit.wikimedia.org/r/240662
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7db5b10393376a6c11ba399abf13f18cb50365e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
