Jeroen De Dauw has submitted this change and it was merged. Change subject: Revert "Replace deprecated $wgSpecialPageGroups" ......................................................................
Revert "Replace deprecated $wgSpecialPageGroups" This breaks compatibility with MediaWiki 1.19 and 1.20, which are supported by this extension, as per README. Please submit changes to this extension at https://github.com/SemanticMediaWiki/SemanticWatchlist so the CI runs before merge. Legoktm: please do not abuse your merge rights here This reverts commit f934497b3d8b170f6000f839ba0d2eb597d6e0ba. Change-Id: Ib5c8681567c997fd0991a927dbf81d6ea20dc9e5 --- M SemanticWatchlist.php M specials/SpecialSemanticWatchlist.php M specials/SpecialWatchlistConditions.php 3 files changed, 2 insertions(+), 6 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved diff --git a/SemanticWatchlist.php b/SemanticWatchlist.php index 22d5f4c..c56f32d 100644 --- a/SemanticWatchlist.php +++ b/SemanticWatchlist.php @@ -70,8 +70,10 @@ $GLOBALS['wgAutoloadClasses']['SpecialWatchlistConditions'] = __DIR__ . '/specials/SpecialWatchlistConditions.php'; $GLOBALS['wgSpecialPages']['SemanticWatchlist'] = 'SpecialSemanticWatchlist'; +$GLOBALS['wgSpecialPageGroups']['SemanticWatchlist'] = 'changes'; $GLOBALS['wgSpecialPages']['WatchlistConditions'] = 'SpecialWatchlistConditions'; +$GLOBALS['wgSpecialPageGroups']['WatchlistConditions'] = 'changes'; $GLOBALS['wgAPIModules']['addswlgroup'] = 'ApiAddWatchlistGroup'; $GLOBALS['wgAPIModules']['deleteswlgroup'] = 'ApiDeleteWatchlistGroup'; diff --git a/specials/SpecialSemanticWatchlist.php b/specials/SpecialSemanticWatchlist.php index 5e68468..5312518 100644 --- a/specials/SpecialSemanticWatchlist.php +++ b/specials/SpecialSemanticWatchlist.php @@ -440,7 +440,4 @@ return $group !== false; } - protected function getGroupName() { - return 'changes'; - } } diff --git a/specials/SpecialWatchlistConditions.php b/specials/SpecialWatchlistConditions.php index b1c7fa6..3108172 100644 --- a/specials/SpecialWatchlistConditions.php +++ b/specials/SpecialWatchlistConditions.php @@ -135,7 +135,4 @@ ); } - protected function getGroupName() { - return 'changes'; - } } -- To view, visit https://gerrit.wikimedia.org/r/241044 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5c8681567c997fd0991a927dbf81d6ea20dc9e5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticWatchlist Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
