Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/241320
Change subject: Fixed Style/IndentationWidth RuboCop offense
......................................................................
Fixed Style/IndentationWidth RuboCop offense
Bug: T113846
Change-Id: Iad732b3fad265f56507d61fccb500a1a1b3aae31
---
M .rubocop_todo.yml
M tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
M tests/browser/features/support/pages/editable_random_page.rb
M tests/browser/features/support/pages/registration_page.rb
4 files changed, 10 insertions(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted
refs/changes/20/241320/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 8289761..fa78326 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -6,15 +6,6 @@
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
-# Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: Width.
-Style/IndentationWidth:
- Exclude:
- -
'tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb'
- - 'tests/browser/features/support/pages/editable_random_page.rb'
- - 'tests/browser/features/support/pages/registration_page.rb'
-
# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
diff --git
a/tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
b/tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
index 65ad737..0b0add9 100644
---
a/tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
+++
b/tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
@@ -1,26 +1,26 @@
When(/^I register$/) do
- @original_title = on(EditableRandomPage).title
+ @original_title = on(EditableRandomPage).title
on(EditableRandomPage).create_account_element.click
on(RegistrationPage).register_user "Test Account #{ @random_string }"
end
Then(/^I should be returned to the same article$/) do
- expect(on(EditableRandomPage).title).to eq @original_title
+ expect(on(EditableRandomPage).title).to eq @original_title
end
Then(/^I should see a modal call to action$/) do
- expect(on(EditableRandomPage).cta_element.when_present).to be_visible
+ expect(on(EditableRandomPage).cta_element.when_present).to be_visible
end
Then(/^one action is edit this page$/) do
- expect(on(EditableRandomPage).edit_this_page_element).to be_visible
+ expect(on(EditableRandomPage).edit_this_page_element).to be_visible
end
Then(/^one action is edit a suggested page$/) do
- expect(on(EditableRandomPage).edit_suggested_page_element).to be_visible
+ expect(on(EditableRandomPage).edit_suggested_page_element).to
be_visible
end
Then(/^one action is no thanks, maybe later$/) do
- expect(on(EditableRandomPage).no_thanks_element).to be_visible
+ expect(on(EditableRandomPage).no_thanks_element).to be_visible
end
diff --git a/tests/browser/features/support/pages/editable_random_page.rb
b/tests/browser/features/support/pages/editable_random_page.rb
index e37a707..0d39ae9 100644
--- a/tests/browser/features/support/pages/editable_random_page.rb
+++ b/tests/browser/features/support/pages/editable_random_page.rb
@@ -1,5 +1,5 @@
class EditableRandomPage < RandomPage
- h1(:title, id: "firstHeading")
+ h1(:title, id: "firstHeading")
div(:cta, id: "mw-gettingstarted-cta-editable-main-page")
a(:edit_this_page, id: "mw-gettingstarted-editable-main-edit-page")
a(:edit_suggested_page, id: "mw-gettingstarted-editable-main-fix-pages")
diff --git a/tests/browser/features/support/pages/registration_page.rb
b/tests/browser/features/support/pages/registration_page.rb
index 0ab4db6..927c66c 100644
--- a/tests/browser/features/support/pages/registration_page.rb
+++ b/tests/browser/features/support/pages/registration_page.rb
@@ -1,5 +1,5 @@
class RegistrationPage
- include PageObject
+ include PageObject
text_field(:username, id: "wpName2")
text_field(:password, id: "wpPassword2")
@@ -8,13 +8,13 @@
a(:return_to, css: "#mw-returnto a")
def register_user(username)
- self.username = username
+ self.username = username
password = Random.new.rand.to_s
self.password = password
self.password_confirmation = password
if ENV.key?("MEDIAWIKI_CAPTCHA_BYPASS_PASSWORD")
- bypass_script = <<-END
+ bypass_script = <<-END
var $bypass = $( '<input>' ).attr( {
type: 'hidden',
name: 'captchabypass',
--
To view, visit https://gerrit.wikimedia.org/r/241320
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad732b3fad265f56507d61fccb500a1a1b3aae31
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
