jenkins-bot has submitted this change and it was merged.
Change subject: Remove tabItem label hack, rely on item config working
......................................................................
Remove tabItem label hack, rely on item config working
Depends on Iacd301863 in oojs-ui being released to MW.
Change-Id: I5de2af77cda08f2de2af44dfefd19c421ea89e0a
---
M modules/ve.ui.CiteFromIdInspector.js
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve.ui.CiteFromIdInspector.js
b/modules/ve.ui.CiteFromIdInspector.js
index 23f6cc2..95cf3ba 100644
--- a/modules/ve.ui.CiteFromIdInspector.js
+++ b/modules/ve.ui.CiteFromIdInspector.js
@@ -134,11 +134,6 @@
} )
};
- // TODO: Remove this when upstream patch for labels lands
- this.modePanels.auto.setupTabItem = this.modePanels.manual.setupTabItem
= this.modePanels.reuse.setupTabItem = function () {
- this.tabItem.setLabel( ve.msg( 'citoid-citefromiddialog-mode-'
+ this.getName() ) );
- };
-
// Auto mode
this.autoProcessStack = new OO.ui.StackLayout( {
expanded: false,
--
To view, visit https://gerrit.wikimedia.org/r/239824
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5de2af77cda08f2de2af44dfefd19c421ea89e0a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Citoid
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits