Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/242109
Change subject: Updated RuboCop to the latest version ...................................................................... Updated RuboCop to the latest version Also: - explicitly set csscss version - removed obsolete RVM configuration from Gemfile - regenerated .rubocop_todo.yml file - updated .rubocop.yml with recommended configuration https://www.mediawiki.org/wiki/Manual:Coding_conventions/Ruby#Base_confi guration Change-Id: Iee78543e46d4613ff2c765e4c3ad6c6f3b049202 --- M .rubocop.yml M .rubocop_todo.yml M Gemfile M Gemfile.lock 4 files changed, 20 insertions(+), 29 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo refs/changes/09/242109/1 diff --git a/.rubocop.yml b/.rubocop.yml index 7ce21af..e4392ba 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,21 +1,13 @@ inherit_from: .rubocop_todo.yml -Metrics/AbcSize: - Enabled: false +AllCops: + StyleGuideCopsOnly: true -Metrics/ClassLength: - Enabled: false - -Metrics/CyclomaticComplexity: - Enabled: false +# uncomment when the offese is fixed +# Metrics/LineLength: +# Max: 100 Metrics/MethodLength: - Enabled: false - -Metrics/ParameterLists: - Enabled: false - -Metrics/PerceivedComplexity: Enabled: false Style/Alias: @@ -23,3 +15,9 @@ Style/SignalException: Enabled: false + +Style/StringLiterals: + EnforcedStyle: single_quotes + +Style/TrivialAccessors: + ExactNameMatch: true diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 0649914..3857e04 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,16 +1,12 @@ -# This configuration was generated by `rubocop --auto-gen-config` -# on 2015-02-23 09:43:04 -0700 using RuboCop version 0.29.0. +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2015-09-29 12:45:22 +0200 using RuboCop version 0.34.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 2 +# Offense count: 6 # Configuration parameters: AllowURI, URISchemes. Metrics/LineLength: - Max: 113 - -# Offense count: 1 -# Configuration parameters: AllowedVariables. -Style/GlobalVars: - Enabled: false + Max: 108 diff --git a/Gemfile b/Gemfile index 2e8abbd..25c3dbe 100644 --- a/Gemfile +++ b/Gemfile @@ -1,8 +1,5 @@ -# ruby=ruby-2.1.1 -# ruby-gemset=Echo - source 'https://rubygems.org' -gem 'csscss' +gem 'csscss', '~> 1.3.3' gem 'mediawiki_selenium', '~> 1.4.0' -gem 'rubocop', require: false +gem 'rubocop', '~> 0.34.2', require: false diff --git a/Gemfile.lock b/Gemfile.lock index 5a81931..35a5a70 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -102,9 +102,9 @@ ruby DEPENDENCIES - csscss + csscss (~> 1.3.3) mediawiki_selenium (~> 1.4.0) - rubocop BUNDLED WITH 1.10.5 + rubocop (~> 0.34.2) -- To view, visit https://gerrit.wikimedia.org/r/242109 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iee78543e46d4613ff2c765e4c3ad6c6f3b049202 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
