Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/242794
Change subject: Add type hints to GlobeCoordinateValueComparer ...................................................................... Add type hints to GlobeCoordinateValueComparer Change-Id: Id04994fd4d80038c1cbab8e73940d7a0f366b7d9 --- M includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityExternalValidation refs/changes/94/242794/1 diff --git a/includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php b/includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php index 41bba39..5e53d25 100644 --- a/includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php +++ b/includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php @@ -26,6 +26,11 @@ throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' ); } + /** + * @var GlobeCoordinateValue $value + * @var GlobeCoordinateValue $comparativeValue + */ + $precision = $value->getPrecision(); $locLat = $value->getLatitude(); $locLong = $value->getLongitude(); -- To view, visit https://gerrit.wikimedia.org/r/242794 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id04994fd4d80038c1cbab8e73940d7a0f366b7d9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits