Henning Snater has submitted this change and it was merged. Change subject: (minor) fixed aliases related error in $.entityselector ......................................................................
(minor) fixed aliases related error in $.entityselector When first suggested item doesn't have a label, but a matching alias, this did trigger an error. Now we explicitly assume that the label can be empty (undefined). Also tidied up code a little by declaring local variables rather than using the same long forms several times. Change-Id: I817c84744a37821b2069581a279df3fd184937c0 --- M lib/resources/jquery.ui/jquery.ui.entityselector.js M lib/resources/jquery.ui/jquery.ui.suggester.js 2 files changed, 16 insertions(+), 10 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/38332 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I817c84744a37821b2069581a279df3fd184937c0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <[email protected]> Gerrit-Reviewer: Henning Snater <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
