Andrew Bogott has submitted this change and it was merged. Change subject: Gerrit role: dequote booleans ......................................................................
Gerrit role: dequote booleans The config file generated from this is meant to be in the format of a git config, which does not quote booleans. Erb should be able to insert bools just fine. Bug: T113783 Change-Id: I1e9c8f2d9c80c7f44367b51024f3e8747075027d --- M manifests/role/gerrit.pp 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Andrew Bogott: Looks good to me, approved jenkins-bot: Verified diff --git a/manifests/role/gerrit.pp b/manifests/role/gerrit.pp index a44c19a..ef0fb0d 100644 --- a/manifests/role/gerrit.pp +++ b/manifests/role/gerrit.pp @@ -62,7 +62,7 @@ # lint:endignore ], 'threads' => '4', - 'mirror' => 'true', + 'mirror' => true, }, 'gitblit' => { # Note: This is in single quotes on purpose. ${name} is not @@ -74,7 +74,7 @@ 'threads' => '4', 'authGroup' => 'mediawiki-replication', 'push' => '+refs/*:refs/*', - 'mirror' => 'true', + 'mirror' => true, }, 'github' => { # Note: This is in single quotes on purpose. ${name} is not @@ -87,7 +87,7 @@ 'authGroup' => 'mediawiki-replication', 'push' => $replication_basic_push_refs, 'remoteNameStyle' => 'dash', - 'mirror' => 'true', + 'mirror' => true, }, # Do not add custom mirrors for GitHub here! # Instead let the default replication happen and perform the rename -- To view, visit https://gerrit.wikimedia.org/r/241240 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e9c8f2d9c80c7f44367b51024f3e8747075027d Gerrit-PatchSet: 6 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Andrew Bogott <abog...@wikimedia.org> Gerrit-Reviewer: Andrew Bogott <abog...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits