Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/243159
Change subject: Add tests ...................................................................... Add tests Fix all issues so tests pass. Change-Id: Ifa53fe57532fcb8d58819900916b613ae20baa91 --- A .gitignore A Gruntfile.js A composer.json A package.json A phpcs.xml M specials/SpecialTwnMainPage.php 6 files changed, 61 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TwnMainPage refs/changes/59/243159/1 diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..854a2d2 --- /dev/null +++ b/.gitignore @@ -0,0 +1,6 @@ +*~ +*.kate-swp +.*.swp +node_modules/ +/composer.lock +/vendor/ diff --git a/Gruntfile.js b/Gruntfile.js new file mode 100644 index 0000000..9c56558 --- /dev/null +++ b/Gruntfile.js @@ -0,0 +1,20 @@ +/*jshint node:true */ +module.exports = function ( grunt ) { + grunt.loadNpmTasks( 'grunt-banana-checker' ); + grunt.loadNpmTasks( 'grunt-jsonlint' ); + + grunt.initConfig( { + banana: { + all: 'i18n/' + }, + jsonlint: { + all: [ + '**/*.json', + '!node_modules/**' + ] + } + } ); + + grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] ); + grunt.registerTask( 'default', 'test' ); +}; diff --git a/composer.json b/composer.json new file mode 100644 index 0000000..4365e8a --- /dev/null +++ b/composer.json @@ -0,0 +1,12 @@ +{ + "require-dev": { + "jakub-onderka/php-parallel-lint": "0.9", + "mediawiki/mediawiki-codesniffer": "0.4.0" + }, + "scripts": { + "test": [ + "parallel-lint . --exclude vendor", + "phpcs -p -s" + ] + } +} diff --git a/package.json b/package.json new file mode 100644 index 0000000..76e8a82 --- /dev/null +++ b/package.json @@ -0,0 +1,12 @@ +{ + "private": true, + "scripts": { + "test": "grunt test" + }, + "devDependencies": { + "grunt": "0.4.5", + "grunt-cli": "0.1.13", + "grunt-banana-checker": "0.2.2", + "grunt-jsonlint": "1.0.4" + } +} diff --git a/phpcs.xml b/phpcs.xml new file mode 100644 index 0000000..d81a292 --- /dev/null +++ b/phpcs.xml @@ -0,0 +1,8 @@ +<?xml version="1.0"?> +<ruleset> + <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/> + <file>.</file> + <arg name="extensions" value="php,php5,inc"/> + <arg name="encoding" value="utf8"/> + <exclude-pattern>vendor</exclude-pattern> +</ruleset> diff --git a/specials/SpecialTwnMainPage.php b/specials/SpecialTwnMainPage.php index f18d0c6..bf92300 100644 --- a/specials/SpecialTwnMainPage.php +++ b/specials/SpecialTwnMainPage.php @@ -39,7 +39,7 @@ array( 'name' => 'twnmp-s-projects', 'stats' => $stats['projects'], - 'url' => Title::makeTitle( NS_CATEGORY, 'Supported projects')->getLocalUrl(), + 'url' => Title::makeTitle( NS_CATEGORY, 'Supported projects' )->getLocalUrl(), ), array( 'name' => 'twnmp-s-translators', @@ -58,10 +58,11 @@ array( 'name' => 'twnmp-s-languages', 'stats' => $stats['languages'], - 'url' => SpecialPage::getTitleFor( 'SupportedLanguages' )->getLocalUrl(), + 'url' => SpecialPage::getTitleFor( 'SupportedLanguages' )->getLocalUrl(), ), ), ); + return $data; } @@ -331,7 +332,6 @@ <div class="twelve columns action">$view</div> HTML; - } else { return <<<HTML <div class="six columns action">$translate</div> -- To view, visit https://gerrit.wikimedia.org/r/243159 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifa53fe57532fcb8d58819900916b613ae20baa91 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TwnMainPage Gerrit-Branch: master Gerrit-Owner: Siebrand <siebr...@kitano.nl> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits