jenkins-bot has submitted this change and it was merged.
Change subject: proofreadpage.py: Fix an error in tests and errors in docstrings
......................................................................
proofreadpage.py: Fix an error in tests and errors in docstrings
Change-Id: Id9943d7c8a0432495bb6415fb792e0d54c6de452
---
M pywikibot/proofreadpage.py
M tests/proofreadpage_tests.py
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/proofreadpage.py b/pywikibot/proofreadpage.py
index a14e2f2..4da5401 100644
--- a/pywikibot/proofreadpage.py
+++ b/pywikibot/proofreadpage.py
@@ -478,7 +478,7 @@
There is a 1-to-many correspondence (a label can be the same for
several pages).
- @return: list containing page numbers corresponding to page label.
+ @return: set containing page numbers corresponding to page label.
"""
return self._get_from_label(self._page_numbers_from_label, label)
@@ -488,6 +488,6 @@
There is a 1-to-many correspondence (a label can be the same for
several pages).
- @return: list containing pages corresponding to page label.
+ @return: set containing pages corresponding to page label.
"""
return self._get_from_label(self._pages_from_label, label)
diff --git a/tests/proofreadpage_tests.py b/tests/proofreadpage_tests.py
index b16ec0e..761e68a 100644
--- a/tests/proofreadpage_tests.py
+++ b/tests/proofreadpage_tests.py
@@ -345,7 +345,7 @@
# Error if page does not exists.
self.assertRaises(KeyError, index_page.get_label_from_page, None)
- def test_get_page_number(self, key):
+ def test_get_page_and_number(self, key):
"""Test IndexPage page get_page_number functions."""
data = self.sites[key]
index_page = IndexPage(self.site, self.sites[key]['index'])
@@ -380,7 +380,7 @@
n = index_page._numbers_from_page[p]
self.assertEqual(index_page._page_from_numbers[n], p)
for n in num_set:
- n = index_page._page_from_numbers[p]
+ p = index_page._page_from_numbers[n]
self.assertEqual(index_page._numbers_from_page[p], n)
def test_page_number_mapping(self, key):
--
To view, visit https://gerrit.wikimedia.org/r/242751
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9943d7c8a0432495bb6415fb792e0d54c6de452
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa <mpaa.w...@gmail.com>
Gerrit-Reviewer: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
