Jeroen De Dauw has submitted this change and it was merged. Change subject: Moved label+descrption check out of transaction to avoid deadlocks ......................................................................
Moved label+descrption check out of transaction to avoid deadlocks Also * Moved duplicate detection code into dedicated class * Only make edits fail for conflicts between terms that actually changed in the edit * Added tests on the level of the new class * Seggregated getMatchingTermCombination off from TermCache Change-Id: If3a528e55ccfacd30fbe706f9ef7360f6a6c3075 --- M repo/Wikibase.hooks.php M repo/Wikibase.php M repo/includes/EditEntity.php A repo/includes/LabelDescriptionDuplicateDetector.php M repo/includes/content/ItemContent.php M repo/includes/store/TermCache.php A repo/includes/store/TermCombinationMatchFinder.php A repo/tests/phpunit/includes/LabelDescriptionDuplicateDetectorTest.php M repo/tests/phpunit/includes/content/ItemContentTest.php 9 files changed, 504 insertions(+), 105 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/38324 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3a528e55ccfacd30fbe706f9ef7360f6a6c3075 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: John Erling Blad <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
